Updated packages

Author: binarymist

.eslintrc.js

@@ -1,5 +1,5 @@
 module.exports = {
-  'extends': 'airbnb-base',
+  extends: 'airbnb-base',
   rules: {
     'comma-dangle': ['error', 'never'],
 
@@ -12,16 +12,15 @@ module.exports = {
       ignoreStrings: true,
       ignoreTemplateLiterals: true
     }],
-        // enforce consistent line breaks inside function parentheses
+    // enforce consistent line breaks inside function parentheses
     // https://eslint.org/docs/rules/function-paren-newline
     'function-paren-newline': ['error', 'multiline'],
-    'import/no-unresolved': [{commonjs: true}],
-    'no-unused-expressions': ["error", { 'allowShortCircuit': true, 'allowTernary': true }],
-    'object-curly-newline': ['error', { 'multiline': true }],
+    'import/no-unresolved': ['error', { commonjs: true }],
+    'no-unused-expressions': ['error', { allowShortCircuit: true, allowTernary: true }],
+    'object-curly-newline': ['error', { multiline: true }],
+    'no-multiple-empty-lines': ['error', { max: 2, maxBOF: 0, maxEOF: 1 }],
     // For logging:
     'no-console': 'off'
   },
-  env: {
-    'node': true
-  }
+  env: { node: true }
 };

cloud/app-slave-provisioner/index.js

@@ -1,5 +1,5 @@
 // Doc: https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ECS.html
-const ECS = require('aws-sdk/clients/ecs');
+const ECS = require('aws-sdk/clients/ecs'); // eslint-disable-line import/no-unresolved
 
 const internals = {};
 
@@ -76,7 +76,7 @@ internals.deploySlaves = async (dTOItems, {
 
   const ecs = new ECS({ region: process.env.AWS_REGION });
 
-  const browserCounts = dTOItems.map(cV => cV.browser).reduce((accumulator, currentValue) => {
+  const browserCounts = dTOItems.map((cV) => cV.browser).reduce((accumulator, currentValue) => {
     accumulator[currentValue] = 1 + (accumulator[currentValue] || 0);
     return accumulator;
   }, {});
@@ -100,14 +100,14 @@ internals.deploySlaves = async (dTOItems, {
     return itemClone;
   });
   console.info(`The value of itemsWithExtras is: ${JSON.stringify(itemsWithExtras)}`);
-  const appItemsWithExtras = itemsWithExtras.map(item => ({
+  const appItemsWithExtras = itemsWithExtras.map((item) => ({
     containerName: item.appSlaveContainerName,
     taskDefinition: item.appSlaveTaskDefinition,
     ecsServiceName: item.appEcsServiceName,
     serviceDiscoveryServiceArn: item.appServiceDiscoveryServiceArn,
     containerPort: 8080
   }));
-  const seleniumItemsWithExtras = itemsWithExtras.map(item => ({
+  const seleniumItemsWithExtras = itemsWithExtras.map((item) => ({
     containerName: item.seleniumContainerName,
     taskDefinition: item.seleniumTaskDefinition,
     ecsServiceName: item.seleniumEcsServiceName,
@@ -117,7 +117,7 @@ internals.deploySlaves = async (dTOItems, {
   const splitItemsWithExtras = [...appItemsWithExtras, ...seleniumItemsWithExtras];
   console.info(`The value of splitItemsWithExtras is: ${JSON.stringify(splitItemsWithExtras)}`);
 
-  const promisedResponses = splitItemsWithExtras.map(cV => ecs.createService({
+  const promisedResponses = splitItemsWithExtras.map((cV) => ecs.createService({
     cluster: customerClusterArn,
     serviceName: cV.ecsServiceName,
     taskDefinition: cV.taskDefinition,
@@ -133,7 +133,7 @@ internals.deploySlaves = async (dTOItems, {
   try {
     const resolved = await promiseAllTimeout(promisedResponses, s2ProvisioningTimeout);
     console.info(`The data objects returned from calling ecs.createService were: ${JSON.stringify(resolved)}`);
-    resolved.every(e => !e) && (result.error = 'Timeout exceeded: App Slave container(s) took too long to start. Although they timed out, they may have still started.');
+    resolved.every((e) => !e) && (result.error = 'Timeout exceeded: App Slave container(s) took too long to start. Although they timed out, they may have still started.');
   } catch (e) {
     console.error('Exception occurred, details follow:');
     console.error(e);

cloud/s2-deprovisioner/index.js

@@ -1,5 +1,5 @@
 // Doc: https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ECS.html
-const ECS = require('aws-sdk/clients/ecs');
+const ECS = require('aws-sdk/clients/ecs'); // eslint-disable-line import/no-unresolved
 
 const internals = {};
 
@@ -55,7 +55,7 @@ internals.downContainers = async (ecsServiceNames, { clientContext: { Custom: {
   const { promiseAllTimeout, s2ProvisioningTimeout } = internals;
   const ecs = new ECS({ region: process.env.AWS_REGION });
 
-  const promisedResponses = ecsServiceNames.map(sN => ecs.deleteService({
+  const promisedResponses = ecsServiceNames.map((sN) => ecs.deleteService({
     cluster: customerClusterArn,
     service: sN,
     force: true
@@ -64,7 +64,7 @@ internals.downContainers = async (ecsServiceNames, { clientContext: { Custom: {
 
   console.info(`These are the values returned from ecs.deleteService: ${JSON.stringify(resolved)}`);
 
-  return resolved.every(e => !!e)
+  return resolved.every((e) => !!e)
     ? { item: `Stage Two ECS services (${JSON.stringify(ecsServiceNames)}) have been brought down.` }
     : { error: `Timeout exceeded while attempting to bring the ECS service(s) (${ecsServiceNames}) down. One or more may still be running.` };
 };

local/s2-deprovisioner/index.js

@@ -55,10 +55,10 @@ internals.downContainers = async (containerNames) => {
   const http = axios.create({ /* default is 0 (no timeout) */ baseURL: 'http://docker-compose-ui:5000/api/v1', headers: { 'Content-type': 'application/json' } });
   const s2ProjectNames = [...containerNames];
 
-  const promisedResponses = s2ProjectNames.map(pN => http.post('/down', { id: pN }));
+  const promisedResponses = s2ProjectNames.map((pN) => http.post('/down', { id: pN }));
   const resolved = await promiseAllTimeout(promisedResponses, s2ProvisioningTimeout);
 
-  return resolved.every(e => !!e)
+  return resolved.every((e) => !!e)
     ? { item: `Stage Two projects (${s2ProjectNames}) have been brought down.` }
     : { error: `Timeout exceeded while attempting to bring the Stage Two projects (${s2ProjectNames}) down. One or more may still be running.` };
 };

local/selenium-standalone-provisioner/index.js

@@ -59,15 +59,15 @@ internals.deploySeleniumStandalones = async (dTOItems) => {
 
   const http = axios.create({ /* default is 0 (no timeout) */ baseURL: 'http://docker-compose-ui:5000/api/v1', headers: { 'Content-type': 'application/json' } });
 
-  const browserCounts = dTOItems.map(cV => cV.browser).reduce((accumulator, currentValue) => {
+  const browserCounts = dTOItems.map((cV) => cV.browser).reduce((accumulator, currentValue) => {
     accumulator[currentValue] = 1 + (accumulator[currentValue] || 0);
     return accumulator;
   }, {});
 
-  const promisedResponses = Object.keys(browserCounts).map(b => http.put('/services', { service: b, project: 'selenium-standalone', num: browserCounts[b] }));
+  const promisedResponses = Object.keys(browserCounts).map((b) => http.put('/services', { service: b, project: 'selenium-standalone', num: browserCounts[b] }));
   const resolved = await promiseAllTimeout(promisedResponses, s2ProvisioningTimeout);
 
-  resolved.every(e => !e) && (result.error = 'Timeout exceeded: Selenium Standalone container(s) took too long to start. Although they timed out, they may have still started. Also check that docker-compose-ui is up.');
+  resolved.every((e) => !e) && (result.error = 'Timeout exceeded: Selenium Standalone container(s) took too long to start. Although they timed out, they may have still started. Also check that docker-compose-ui is up.');
 
   const numberOfSeleniumStandaloneServiceNamesToAdd = { ...browserCounts };
   const runningCountOfSeleniumStandaloneServiceNamesLeftToAdd = { ...browserCounts };