Fix "creation" of empty built-in firewall chains #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david22swan
approved these changes
May 22, 2024
Member
david22swan
left a comment
david22swan
left a comment
There was a problem hiding this comment.
LGTM
Thanks for catching this.
Ramesh7
approved these changes
May 22, 2024
This was referenced Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue when you are trying to create an in-built firewall chain in a table that was not been interacted with before.
Additional Context
Currently if you are trying to create in-built chain in an empty table (nat, for example) puppet will apply manifest without actually doing anything every time you run it. This is because firewall module relyes on
iptables-saveoutput that will not contain in-built chain if corresponding table not been interacted with yet.Checklist
puppet apply)