fix: boolean import (#642)

Author: psteinroe

.changeset/kind-swans-add.md

@@ -0,0 +1,5 @@
+---
+"@supabase-cache-helpers/postgrest-server": patch
+---
+
+fix: dont eval 'false' as empty

examples/react-query/types/database.ts

@@ -277,6 +277,10 @@ export type Database = {
       [_ in never]: never;
     };
     Functions: {
+      boolean_return: {
+        Args: Record<PropertyKey, never>;
+        Returns: boolean;
+      };
       contacts_cursor: {
         Args: {
           v_username_cursor?: string;

examples/swr/types/database.ts

@@ -277,6 +277,10 @@ export type Database = {
       [_ in never]: never;
     };
     Functions: {
+      boolean_return: {
+        Args: Record<PropertyKey, never>;
+        Returns: boolean;
+      };
       contacts_cursor: {
         Args: {
           v_username_cursor?: string;

packages/postgrest-core/tests/database.types.ts

@@ -277,6 +277,10 @@ export type Database = {
       [_ in never]: never;
     };
     Functions: {
+      boolean_return: {
+        Args: Record<PropertyKey, never>;
+        Returns: boolean;
+      };
       contacts_cursor: {
         Args: {
           v_username_cursor?: string;

packages/postgrest-react-query/tests/database.types.ts

@@ -277,6 +277,10 @@ export type Database = {
       [_ in never]: never;
     };
     Functions: {
+      boolean_return: {
+        Args: Record<PropertyKey, never>;
+        Returns: boolean;
+      };
       contacts_cursor: {
         Args: {
           v_username_cursor?: string;

packages/postgrest-server/src/utils.ts

@@ -15,7 +15,7 @@ export function isEmpty<Result>(result: Value<Result>) {
     return false;
   }
 
-  if (!result.data) {
+  if (result.data === null || typeof result.data === 'undefined') {
     return true;
   }
 

packages/postgrest-server/tests/query-cache.test.ts

@@ -169,6 +169,27 @@ describe('QueryCache', () => {
       expect(spy).toHaveBeenCalledTimes(2);
     });
 
+    it('should store boolean results', async () => {
+      const map = new Map();
+
+      const cache = new QueryCache(ctx, {
+        stores: [new MemoryStore({ persistentMap: map })],
+        fresh: 1000,
+        stale: 2000,
+      });
+
+      const query = client.rpc('boolean_return').maybeSingle();
+
+      const spy = vi.spyOn(query, 'then');
+
+      const res = await cache.query(query);
+      const res2 = await cache.query(query);
+
+      expect(res.data).toBe(false);
+      expect(res2.data).toBe(false);
+      expect(spy).toHaveBeenCalledTimes(1);
+    });
+
     it('should not store result if store() returns false', async () => {
       const map = new Map();
 

packages/postgrest-swr/tests/database.types.ts

@@ -109,7 +109,6 @@ export type Database = {
           tags?: string[] | null;
           ticket_number?: number | null;
           username?: string | null;
-          has_low_ticket_number?: boolean | null;
         };
         Update: {
           age_range?: unknown | null;
@@ -123,7 +122,6 @@ export type Database = {
           tags?: string[] | null;
           ticket_number?: number | null;
           username?: string | null;
-          has_low_ticket_number?: boolean | null;
         };
         Relationships: [
           {
@@ -279,6 +277,10 @@ export type Database = {
       [_ in never]: never;
     };
     Functions: {
+      boolean_return: {
+        Args: Record<PropertyKey, never>;
+        Returns: boolean;
+      };
       contacts_cursor: {
         Args: {
           v_username_cursor?: string;

supabase/migrations/20240311151149_add_boolean_rpc.sql

@@ -0,0 +1,5 @@
+create or replace function public.boolean_return() returns boolean
+as $$
+select false;
+$$ language sql stable set search_path = '';
+