Remove what appears to be an un-needed call to self.resolve_redirects when not following redirects as part of creating a request's history. #5492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when not following redirects as part of creating a request's history.
dbaxa
force-pushed
the
avoid-calling-resolve_redirects-whe-not-following-redirects
branch
from
3837895 to
fa2dbe9
Compare
Contributor
|
At one point, Good catch. @nateprewitt @sethmlarson this PR looks good |
Contributor
Author
|
@sigmavirus24 let me know if you want me to fix up the source branch name and or commit message :-) . |
Contributor
|
I'm not a maintainer so not my call. 🙂 |
nateprewitt
approved these changes
Jun 15, 2020
Member
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Yep, this is a great catch. Thanks @dbaxa!
Merged
This was referenced Mar 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.