Skip to content

Commit e87f3a1

Browse files
committed
re-add utf8 where needed
Signed-off-by: Owen Williams <[email protected]>
1 parent 905ec83 commit e87f3a1

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

tests/openmetrics/test_exposition.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
Exemplar, GaugeHistogramMetricFamily, Timestamp,
1111
)
1212
from prometheus_client.openmetrics.exposition import (
13-
DOTS, escape_label_name, escape_metric_name, generate_latest,
13+
ALLOWUTF8, DOTS, escape_label_name, escape_metric_name, generate_latest,
1414
UNDERSCORES, VALUES,
1515
)
1616

@@ -43,7 +43,7 @@ def test_counter_utf8(self):
4343
c = Counter('cc.with.dots', 'A counter', registry=self.registry)
4444
c.inc()
4545
self.assertEqual(b'# HELP "cc.with.dots" A counter\n# TYPE "cc.with.dots" counter\n{"cc.with.dots_total"} 1.0\n{"cc.with.dots_created"} 123.456\n# EOF\n',
46-
generate_latest(self.registry))
46+
generate_latest(self.registry, ALLOWUTF8))
4747

4848
def test_counter_utf8_escaped_underscores(self):
4949
c = Counter('utf8.cc', 'A counter', registry=self.registry)

tests/test_exposition.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def test_counter(self):
4747
# HELP cc_created A counter
4848
# TYPE cc_created gauge
4949
cc_created 123.456
50-
""", generate_latest(self.registry))
50+
""", generate_latest(self.registry, openmetrics.ALLOWUTF8))
5151

5252
def test_counter_utf8(self):
5353
c = Counter('utf8.cc', 'A counter', registry=self.registry)
@@ -58,7 +58,7 @@ def test_counter_utf8(self):
5858
# HELP "utf8.cc_created" A counter
5959
# TYPE "utf8.cc_created" gauge
6060
{"utf8.cc_created"} 123.456
61-
""", generate_latest(self.registry))
61+
""", generate_latest(self.registry, openmetrics.ALLOWUTF8))
6262

6363
def test_counter_utf8_escaped_underscores(self):
6464
c = Counter('utf8.cc', 'A counter', registry=self.registry)

tests/test_parser.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
HistogramMetricFamily, Metric, Sample, SummaryMetricFamily,
77
)
88
from prometheus_client.exposition import generate_latest
9+
from prometheus_client.openmetrics.exposition import ALLOWUTF8
910
from prometheus_client.parser import text_string_to_metric_families
1011

1112

@@ -367,7 +368,7 @@ def collect(self):
367368

368369
registry = CollectorRegistry()
369370
registry.register(TextCollector())
370-
self.assertEqual(text.encode('utf-8'), generate_latest(registry))
371+
self.assertEqual(text.encode('utf-8'), generate_latest(registry, ALLOWUTF8))
371372

372373

373374
if __name__ == '__main__':

0 commit comments

Comments
 (0)