From 656d2b4569226780b66bc9167a6ce64e16897eae Mon Sep 17 00:00:00 2001
From: Woody Tseng <tsengwoody.tw@gmail.com>
Date: Mon, 4 Aug 2025 11:11:59 +0800
Subject: [PATCH] Fix "hide banner" button not contained within any landmark
 region

---
 src/components/Banner/index.astro | 2 +-
 src/components/Footer/index.astro | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/Banner/index.astro b/src/components/Banner/index.astro
index 8cef5229a5..0c4c6d50f2 100644
--- a/src/components/Banner/index.astro
+++ b/src/components/Banner/index.astro
@@ -6,7 +6,7 @@ const { link, title } = entry.data;
 ---
 
 <div class="banner bg-accent-color text-accent-type-color" style={{ display: 'none' }} data-title={title}>
-  <a class="banner-content" href={link} target="_blank">
+  <a class="banner-content" href={link} target="_blank" title="Opens in new tab">
     <Content />
   </a>
   <button id="hideBanner" aria-label="Hide banner"><Icon kind="close" /></button>
diff --git a/src/components/Footer/index.astro b/src/components/Footer/index.astro
index 8cb5d3026b..9ea507dea1 100644
--- a/src/components/Footer/index.astro
+++ b/src/components/Footer/index.astro
@@ -61,7 +61,7 @@ const bannerEntry = await getEntry("banner", currentLocale);
       </ul>
     </div>
   </div>
+  {bannerEntry && !bannerEntry.data.hidden && (<Banner entry={bannerEntry} />)}
 </footer>
-{bannerEntry && !bannerEntry.data.hidden && (<Banner entry={bannerEntry} />)}
 
 <style></style>