From 4829c8942a8f4b00d4418ff8550bfb7e6eb29fe5 Mon Sep 17 00:00:00 2001 From: rohit Date: Mon, 19 Apr 2021 02:06:38 +0530 Subject: [PATCH 1/2] Fixing test in monoSynth.js --- test/tests/p5.MonoSynth.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/tests/p5.MonoSynth.js b/test/tests/p5.MonoSynth.js index 1c9e080b..016379e4 100644 --- a/test/tests/p5.MonoSynth.js +++ b/test/tests/p5.MonoSynth.js @@ -12,7 +12,7 @@ describe('p5.MonoSynth', function () { // wait for scheduled value to complete setTimeout(function () { - expect(monoSynth.oscillator.freq().value).to.equal(110); + expect(monoSynth.oscillator.freq().value).to.equal(55); monoSynth.dispose(); done(); }, 1); From 6b5ccb375b0572694bad6342365818f9ff7407f6 Mon Sep 17 00:00:00 2001 From: rohit Date: Wed, 28 Apr 2021 22:50:27 +0530 Subject: [PATCH 2/2] fixing the bug in noteToFreq helper function --- src/helpers.js | 2 +- test/tests/p5.MonoSynth.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/helpers.js b/src/helpers.js index cc252f95..ce6e47ef 100644 --- a/src/helpers.js +++ b/src/helpers.js @@ -86,7 +86,7 @@ function noteToFreq(note) { if (typeof note !== 'string') { return note; } - var wholeNotes = { A: 21, B: 23, C: 24, D: 26, E: 28, F: 29, G: 31 }; + var wholeNotes = { A: 33, B: 35, C: 24, D: 26, E: 28, F: 29, G: 31 }; var value = wholeNotes[note[0].toUpperCase()]; var octave = ~~note.slice(-1); value += 12 * (octave - 1); diff --git a/test/tests/p5.MonoSynth.js b/test/tests/p5.MonoSynth.js index 016379e4..1c9e080b 100644 --- a/test/tests/p5.MonoSynth.js +++ b/test/tests/p5.MonoSynth.js @@ -12,7 +12,7 @@ describe('p5.MonoSynth', function () { // wait for scheduled value to complete setTimeout(function () { - expect(monoSynth.oscillator.freq().value).to.equal(55); + expect(monoSynth.oscillator.freq().value).to.equal(110); monoSynth.dispose(); done(); }, 1);