From 3db03e09c811eade6dd2726b9d463c4c101d0d04 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Tue, 8 Mar 2022 16:35:49 +0100 Subject: [PATCH 1/2] Pull out resolvedColorMode to a different effect --- src/ThemeProvider.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/ThemeProvider.tsx b/src/ThemeProvider.tsx index 89ca306fd3a..1162d939f7e 100644 --- a/src/ThemeProvider.tsx +++ b/src/ThemeProvider.tsx @@ -99,7 +99,11 @@ export const ThemeProvider: React.FC = ({children, ...props} // Update state if props change React.useEffect(() => { setColorMode(props.colorMode ?? fallbackColorMode ?? defaultColorMode) - }, [props.colorMode, resolvedColorMode, fallbackColorMode]) + }, [props.colorMode, fallbackColorMode]) + + React.useEffect(() => { + setColorMode(resolvedColorMode) + }, [resolvedColorMode]) React.useEffect(() => { setDayScheme(props.dayScheme ?? fallbackDayScheme ?? defaultDayScheme) From 5fe0df8daf2d4ad32c687f35bfe3359aa133e90e Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Tue, 8 Mar 2022 16:44:59 +0100 Subject: [PATCH 2/2] Create pretty-cougars-walk.md --- .changeset/pretty-cougars-walk.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/pretty-cougars-walk.md diff --git a/.changeset/pretty-cougars-walk.md b/.changeset/pretty-cougars-walk.md new file mode 100644 index 00000000000..b95f5d245be --- /dev/null +++ b/.changeset/pretty-cougars-walk.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +ThemeProvider: Fix `setColorMode`. Broken in `34.6.0`