Skip to content

chore: remove react-compiler-runtime #6548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Uzlopak
Copy link

@Uzlopak Uzlopak commented Aug 8, 2025

This package was introduced in #6211 but is not used anywhere in the codebase.

@Copilot Copilot AI review requested due to automatic review settings August 8, 2025 21:11
@Uzlopak Uzlopak requested a review from a team as a code owner August 8, 2025 21:11
@Uzlopak Uzlopak requested a review from francinelucca August 8, 2025 21:11
Copy link

changeset-bot bot commented Aug 8, 2025

⚠️ No Changeset found

Latest commit: 03bfcee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused react-compiler-runtime dependency from the @primer/react package. The package was previously added but is not being utilized anywhere in the codebase.

Key Changes

  • Removal of react-compiler-runtime dependency from package.json
  • Clean up of trailing whitespace

@joshblack
Copy link
Member

Hi there! 👋 This package is used as a part of the react compiler transformation here: https://github.com/primer/react/blob/main/packages/react/babel.config.js#L10 from what I understand.

Hope that makes sense! Let me know if you have any questions.

@Uzlopak
Copy link
Author

Uzlopak commented Aug 8, 2025

@joshblack

Thats odd. @primer/react uses react 18, so it needs this shim. But does it need it to be a production dependency?

@joshblack
Copy link
Member

I think so since it's included in our generated files, e.g.: https://app.unpkg.com/@primer/[email protected]/files/lib-esm/Skeleton/SkeletonBox.js

@Uzlopak
Copy link
Author

Uzlopak commented Aug 8, 2025

Thank you for this perspective. Closing this PR ;)

@Uzlopak Uzlopak closed this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants