-
Notifications
You must be signed in to change notification settings - Fork 625
Update ActionBar.examples.stories.tsx to no longer use styled-components #6543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the ActionBar examples stories from styled-components to CSS modules, removing the dependency on the Box
component and inline styling while maintaining the same visual appearance and functionality.
- Replaced all
Box
components with semantic HTML elements (div
,header
) - Created a new CSS module file with equivalent styles using CSS custom properties
- Removed styled-components usage while preserving existing component behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
ActionBar.examples.stories.tsx | Replaced Box components with HTML elements and CSS classes, removed styled-components imports |
ActionBar.examples.stories.module.css | Added CSS module with equivalent styles using design tokens and CSS custom properties |
Closes https://github.com/github/primer/issues/5675
Changelog
New
Added new CSS module
Changed
Changed
ActionBar.examples.stories.tsx
to no longer use styled-componentsRemoved
Removed anything associated with styled-components
Rollout strategy
Testing & Reviewing
Merge checklist