Skip to content

Commit 2868c21

Browse files
authored
Merge branch 'main' into next-major
2 parents 8959aeb + 32b9693 commit 2868c21

File tree

8 files changed

+19
-15
lines changed

8 files changed

+19
-15
lines changed

.changeset/safe-ssr-theming.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.changeset/three-papayas-beg.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
# @primer/components
22

3+
## 34.7.1
4+
5+
### Patch Changes
6+
7+
- [#1936](https://github.com/primer/react/pull/1936) [`ceaaf171`](https://github.com/primer/react/commit/ceaaf17174f08ccccd5223066e456c38b76241c1) Thanks [@siddharthkp](https://github.com/siddharthkp)! - ThemeProvider: Fix `setColorMode`. Broken in `34.6.0`
8+
9+
* [#1913](https://github.com/primer/react/pull/1913) [`92a02377`](https://github.com/primer/react/commit/92a023770f04662a3571de7e87fab8565592bae4) Thanks [@siddharthkp](https://github.com/siddharthkp)! - Fixes the theming implementation with server side rendering to use a CSRF safe approach
10+
11+
- [#1928](https://github.com/primer/react/pull/1928) [`4dc15c33`](https://github.com/primer/react/commit/4dc15c3300838733da39fd2895692cce5bc3a3b5) Thanks [@pksjce](https://github.com/pksjce)! - Add outline background and border color
12+
313
## 34.7.0
414

515
### Minor Changes

docs/content/CheckboxGroup.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
title: CheckboxGroup
3-
description: A `CheckboxGroup` is used to render a set of checkboxes to let users select one or more options
3+
description: Renders a set of checkboxes to let users make one or more selections from a short list of options
44
status: Alpha
55
source: https://github.com/primer/react/blob/main/src/CheckboxGroup/CheckboxGroup.tsx
66
storybook: '/react/storybook/?path=/story/forms-checkboxgroup-examples--basic'

docs/content/FormControl.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
componentId: form_control
33
title: FormControl
44
status: Alpha
5-
description: The FormControl component is used to render a labelled text input and, optionally, associated validation text and hint text.
5+
description: Renders a labelled input and, optionally, associated validation text and/or hint text.
66
source: https://github.com/primer/react/blob/main/src/FormControl/FormControl.tsx
77
storybook: '/react/storybook?path=/story/forms-inputfield--text-input-field'
88
---

docs/content/RadioGroup.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
title: RadioGroup
3-
description: A `RadioGroup` is used to render a set of radio inputs to let users select a single option
3+
description: Renders a set of radio inputs to let users make a single selection from a short list of options
44
status: Alpha
55
source: https://github.com/primer/react/blob/main/src/RadioGroup/RadioGroup.tsx
66
storybook: '/react/storybook/?path=/story/forms-radiogroup-examples--basic'

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@primer/react",
3-
"version": "34.7.0",
3+
"version": "34.7.1",
44
"description": "An implementation of GitHub's Primer Design System using React",
55
"main": "lib/index.js",
66
"module": "lib-esm/index.js",

src/ThemeProvider.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,11 @@ export const ThemeProvider: React.FC<ThemeProviderProps> = ({children, ...props}
9999
// Update state if props change
100100
React.useEffect(() => {
101101
setColorMode(props.colorMode ?? fallbackColorMode ?? defaultColorMode)
102-
}, [props.colorMode, resolvedColorMode, fallbackColorMode])
102+
}, [props.colorMode, fallbackColorMode])
103+
104+
React.useEffect(() => {
105+
setColorMode(resolvedColorMode)
106+
}, [resolvedColorMode])
103107

104108
React.useEffect(() => {
105109
setDayScheme(props.dayScheme ?? fallbackDayScheme ?? defaultDayScheme)

0 commit comments

Comments
 (0)