Remove unnecessary label title (#1826)

PeterYangIO · rezrah · web-flow · commit 004c46231628 · 2022-02-15T23:14:07.000Z
* remove label title

* add changeset

Co-authored-by: Rez &lt;rezrah@github.com&gt;
diff --git a/.changeset/slow-fireants-shave.md b/.changeset/slow-fireants-shave.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+Remove unnecessary "required field" label title in favor for native `required` input attribute
diff --git a/src/_InputLabel.tsx b/src/_InputLabel.tsx
@@ -15,7 +15,6 @@ const InputLabel: React.FC<Props & SxProp> = ({children, disabled, required, vis
       isVisible={!visuallyHidden}
       as="label"
       htmlFor={htmlFor}
-      title={required ? 'required field' : undefined}
       sx={{
         fontWeight: 'bold',
         fontSize: 1,
diff --git a/src/__tests__/InputField.test.tsx b/src/__tests__/InputField.test.tsx
@@ -66,7 +66,7 @@ describe('InputField', () => {
         </SSRProvider>
       )
 
-      const input = getByRole('textbox')
+      const input = getByRole('textbox', {name: TEXTINPUTFIELD_LABEL_TEXT})
 
       expect(input.getAttribute('required')).not.toBeNull()
     })

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@primer/react': patch
 +---
++
 +Remove unnecessary "required field" label title in favor for native `required` input attribute
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ describe('InputField', () => {`
`66`	`66`	`</SSRProvider>`
`67`	`67`	`)`
`68`	`68`
`69`		`- const input = getByRole('textbox')`
	`69`	`+ const input = getByRole('textbox', {name: TEXTINPUTFIELD_LABEL_TEXT})`
`70`	`70`
`71`	`71`	`expect(input.getAttribute('required')).not.toBeNull()`
`72`	`72`	`})`