Merge pull request #1641 from presidentbeef/zero_line_numbers_instead_of_nil

Fix warning sorting with nil line numbers

Author: presidentbeef

lib/brakeman/report/ignore/config.rb

@@ -126,7 +126,7 @@ def save_to_file warnings, file = @file
 
         w[:note] = @notes[w[:fingerprint]] || ""
         w
-      end.sort_by { |w| [w[:fingerprint], w[:line]] }
+      end.sort_by { |w| [w[:fingerprint], w[:line] || 0] }
 
       output = {
         :ignored_warnings => warnings,

lib/brakeman/report/report_csv.rb

@@ -17,7 +17,7 @@ def generate_report
     ]
 
     rows = tracker.filtered_warnings.sort_by do |w|
-      [w.confidence, w.warning_type, w.file, w.line, w.fingerprint]
+      [w.confidence, w.warning_type, w.file, w.line || 0, w.fingerprint]
     end.map do |warning|
       generate_row(headers, warning)
     end

lib/brakeman/report/report_text.rb

@@ -92,7 +92,7 @@ def generate_warnings
       HighLine.color("No warnings found", :bold, :green)
     else
       warnings = tracker.filtered_warnings.sort_by do |w|
-        [w.confidence, w.warning_type, w.file, w.line, w.fingerprint]
+        [w.confidence, w.warning_type, w.file, w.line || 0, w.fingerprint]
       end.map do |w|
         output_warning w
       end