Skip to content

Conversation

@vviikk
Copy link
Contributor

@vviikk vviikk commented Mar 3, 2021

This seems to have fixed it. Could you check? Thanks!

NOTE: Merge this into your PR and then to master. Should work.

@vviikk
Copy link
Contributor Author

vviikk commented Mar 3, 2021

Fixes #6 I believe

@pradel
Copy link
Owner

pradel commented Mar 4, 2021

@vviikk thanks for trying to fix it!
I tried your pr with the with-svgr example and looks like the same error is popping up

create-react-app-esbuild/examples/with-svgr took 7s 
➜ yarn build
Creating an optimized production build...
Failed to compile.

./src/App.js
Attempted import error: 'ReactComponent' is not exported from './logo.svg' (imported as 'Logo').

@pradel
Copy link
Owner

pradel commented Mar 4, 2021

@vviikk actually my bad, looks like I did checkout the wrong commit 🤦
This one is working, amazing!

@pradel pradel changed the title Feature/svgr support fix svgr config Mar 4, 2021
@pradel pradel merged commit ba892f0 into pradel:feature/svgr-support Mar 4, 2021
@vviikk vviikk deleted the feature/svgr-support branch March 4, 2021 07:02
@vviikk
Copy link
Contributor Author

vviikk commented Mar 4, 2021

Glad to help @pradel. You did the heavy lifting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants