Skip to content

Commit daf27e1

Browse files
committed
Review feedback
1 parent c79bfb9 commit daf27e1

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

common/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ structure:
1818
- `androidMain` - Android-specific code for loading the core extension.
1919
- `jvmMain` - Java-specific code for loading the core extension.
2020
- `nativeMain` - A SQLite driver implemented with cinterop calls to sqlite3.
21+
- `appleMain`: Utilities for finding a suitable database location on Apple platforms.
22+
- `appleNonWatchOsMain` and `watchosMain`: Loads the PowerSync core extension (which is linked statically on watchOS
23+
and dynamically on other platforms).
2124

2225
## Attachment Helpers
2326

common/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,8 @@ kotlin {
119119
}
120120

121121
cinterops.create("sqlite3") {
122+
// We're not linking SQLite here (to allow using this package with e.g. SQLCipher or
123+
// SQLite3MultipleCiphers), :core depends on this package and is responsible for bundling SQLite.
122124
packageName("com.powersync.internal.sqlite3")
123125
includeDirs.allHeaders("src/nativeMain/interop/")
124126
definitionFile.set(project.file("src/nativeMain/interop/sqlite3.def"))

common/src/commonMain/kotlin/com/powersync/PowerSyncDatabase.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ public interface PowerSyncDatabase : Queries {
9898
* params = params
9999
* )
100100
* ```
101-
* TODO: Internal Team - Status changes are reported on [statusStream].
102101
*/
103102
@Throws(PowerSyncException::class, CancellationException::class)
104103
public suspend fun connect(

0 commit comments

Comments
 (0)