WIP org.freedesktop.a11y.Manager dbus protocol
#1412
Draft
+455
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
force-pushed
the
a11y-keyboard-monitor_noble
branch
from
a59392b to
cfffaac
Compare
ids1024
force-pushed
the
a11y-keyboard-monitor_noble
branch
2 times, most recently
from
921955f to
9d88398
Compare
Member
Author
|
To restrict interfaces to only certain well-known names, I've added I guess we also need to remove grabs for clients that are disconnected... |
ids1024
force-pushed
the
a11y-keyboard-monitor_noble
branch
2 times, most recently
from
e2c33ed to
fa3302f
Compare
ids1024
force-pushed
the
a11y-keyboard-monitor_noble
branch
from
fa3302f to
a270e51
Compare
ids1024
force-pushed
the
a11y-keyboard-monitor_noble
branch
from
a270e51 to
956a8a4
Compare
|
Any chance this will get completed in time for 1.0? Or can we get the existing at-spi2-core patch upstreamed so that non-pop distros can have working screen reader support? |
ids1024
force-pushed
the
a11y-keyboard-monitor_noble
branch
3 times, most recently
from
73f2dd3 to
3077c34
Compare
If we need to use simple async code in a few places, a single executor may be better than having several threads blocking on async code. This should probably use the calloop executor, but that's had issues in cosmic-workspaces, though that may not apply here.
The `zbus` blocking API just wraps the async API with `block_on`, so we may as well use our own executor.
Allows us to restrict a DBus protocol to only the owners of specific dbus names.
unused code url unichar store set grabs KeyGrab key grabs virtual_mods Fix deadlock fmt WIP serve interfaces
ids1024
force-pushed
the
a11y-keyboard-monitor_noble
branch
from
3077c34 to
6ee5e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the rough incomplete version here, upstream Orca and at-spi2-core are able get key input from the server. More needs to be done to handle grabs correctly, restrict access to the protocol, and make sure all the details work correctly.