feat: Add mongodb v5 support with strict filter types #422
Conversation
| "@typescript-eslint/no-unsafe-argument": "warn", | ||
| "@typescript-eslint/no-unsafe-assignment": "warn", | ||
| "@typescript-eslint/no-unsafe-member-access": "warn", | ||
| "@typescript-eslint/no-unsafe-return": "warn", |
There was a problem hiding this comment.
For some weird reason, the ESLint TS plugin now thinks the type of the update filter variables are any, so let's temporarily downgrade these to warning.
|
Agreed on the major version bump. |
|
What is the TL;DR on the difference between |
|
|
Oh, well that is not bad, so they just decided to isolate the support for dot-notation fields in its own type instead of removing it completely? |
avaly
force-pushed
the
feature/mongodb-v5-strictfilter
branch
from
dde1686 to
662b5ad
Compare
From looking at the changes, I'm having trouble understanding what this would break in external applications. However, since this does involve a major version upgrade of the |
avaly
force-pushed
the
feature/mongodb-v5-strictfilter
branch
3 times, most recently
from
e5a4947 to
e592470
Compare
|
Worth pinning to 5.0.1? https://github.com/mongodb/node-mongodb-native/releases/tag/v5.0.1 (or is that moot with the peerDep set) |
avaly
force-pushed
the
feature/mongodb-v5-strictfilter
branch
from
e592470 to
0534bb7
Compare
|
I updated our dev dependency to 5.0.1, but given the peer dependency version is more of an indicator of breaking changes which we depend on, I'll keep that version declared as |
|
|
||
| Papr is using the strict types to provide type safety for all query and update filters. | ||
|
|
||
| This comes with a caveat: whenever you need to interact with the `mongodb` driver collections, you need to cast filter types to their simple counterparts, since `Filter` is not compatible with `StrictFilter`. |
There was a problem hiding this comment.
This bit of the docs is very nicely written, well done!
avaly
force-pushed
the
feature/mongodb-v5-strictfilter
branch
from
0534bb7 to
ab1e0e4
Compare
avaly
force-pushed
the
feature/mongodb-v5-strictfilter
branch
from
ab1e0e4 to
bba476a
Compare
BREAKING CHANGE: `mongodb` v5 is required as a peer dependency. BREAKING CHANGE: `Filter` and `UpdateFilter` types are now using the strict counterpart types from mongodb v5.
avaly
force-pushed
the
feature/mongodb-v5-strictfilter
branch
from
bba476a to
73b7148
Compare
This PR adds support for
mongodbv5.Together with this we're switching to the
StrictFiltertypes.Because this is changing the implementation of the internal types and has potential to break existing applications, I think this should be a major version bump. Happy to hear other arguments though.
mongodbto5.0.0StrictFiltertypesStrictUpdateFiltertypes