hotfix: omit page_size arg to client call if not provided in subs cli list command (#1102)

* omit page_size if not provided in subs cli list

* format

* add more test coverage

Author: charcey

planet/cli/subscriptions.py

@@ -128,19 +128,24 @@ async def list_subscriptions_cmd(ctx,
                                  pretty):
     """Prints a sequence of JSON-encoded Subscription descriptions."""
     async with subscriptions_client(ctx) as client:
+        list_subscriptions_kwargs = {
+            'created': created,
+            'end_time': end_time,
+            'hosting': hosting,
+            'name__contains': name_contains,
+            'name': name,
+            'source_type': source_type,
+            'start_time': start_time,
+            'status': status,
+            'sort_by': sort_by,
+            'updated': updated,
+            'limit': limit,
+        }
+        if page_size is not None:
+            list_subscriptions_kwargs['page_size'] = page_size
+
         async for sub in client.list_subscriptions(
-                created=created,
-                end_time=end_time,
-                hosting=hosting,
-                name__contains=name_contains,
-                name=name,
-                source_type=source_type,
-                start_time=start_time,
-                status=status,
-                sort_by=sort_by,
-                updated=updated,
-                limit=limit,
-                page_size=page_size):
+                **list_subscriptions_kwargs):
             echo_json(sub, pretty)
 
 

tests/integration/test_subscriptions_api.py

@@ -562,6 +562,16 @@ async def test_list_subscriptions_cycle_break():
             _ = [sub async for sub in client.list_subscriptions()]
 
 
+@pytest.mark.anyio
+@failing_api_mock
+async def test_get_summary_failure():
+    """ServerError is raised if there is an internal server error (500)."""
+    with pytest.raises(ServerError):
+        async with Session() as session:
+            client = SubscriptionsClient(session, base_url=TEST_URL)
+            _ = await client.get_summary()
+
+
 @pytest.mark.anyio
 @summary_mock
 async def test_get_summary():
@@ -601,6 +611,16 @@ def test_get_summary_sync():
     }
 
 
+@pytest.mark.anyio
+@failing_api_mock
+async def test_get_sub_summary_failure():
+    """ServerError is raised if there is an internal server error (500)."""
+    with pytest.raises(ServerError):
+        async with Session() as session:
+            client = SubscriptionsClient(session, base_url=TEST_URL)
+            _ = await client.get_subscription_summary("test")
+
+
 @pytest.mark.anyio
 @sub_summary_mock
 async def test_get_sub_summary():