Keep an uncertain component type as mixed

Author: ondrejmirtes

src/Type/Nette/ComponentModelArrayAccessDynamicReturnTypeExtension.php

@@ -7,7 +7,9 @@
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
+use PHPStan\Type\MixedType;
 use PHPStan\Type\NullType;
+use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use function count;
@@ -38,6 +40,9 @@ public function getTypeFromMethodCall(
 		$calledOnType = $scope->getType($methodCall->var);
 		$defaultType = ParametersAcceptorSelector::selectSingle($calledOnType->getMethod('createComponent', $scope)->getVariants())->getReturnType();
 		$defaultType = TypeCombinator::remove($defaultType, new NullType());
+		if ($defaultType->isSuperTypeOf(new ObjectType('Nette\ComponentModel\IComponent'))->yes()) {
+			$defaultType = new MixedType();
+		}
 		$args = $methodCall->getArgs();
 		if (count($args) !== 1) {
 			return $defaultType;

src/Type/Nette/ComponentModelDynamicReturnTypeExtension.php

@@ -7,7 +7,9 @@
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
+use PHPStan\Type\MixedType;
 use PHPStan\Type\NullType;
+use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use function count;
@@ -37,6 +39,9 @@ public function getTypeFromMethodCall(
 	{
 		$calledOnType = $scope->getType($methodCall->var);
 		$defaultType = ParametersAcceptorSelector::selectSingle($calledOnType->getMethod('createComponent', $scope)->getVariants())->getReturnType();
+		if ($defaultType->isSuperTypeOf(new ObjectType('Nette\ComponentModel\IComponent'))->yes()) {
+			$defaultType = new MixedType();
+		}
 		$args = $methodCall->getArgs();
 		if (count($args) < 1) {
 			return $defaultType;

tests/Type/Nette/data/componentModel.php

@@ -35,16 +35,16 @@ public function createComponent(string $name): AnotherControl {
 
 $someControl = new SomeControl();
 assertType('PHPStan\Type\Nette\Data\ComponentModel\SomeControl', $someControl->getComponent('some'));
-assertType('Nette\ComponentModel\IComponent', $someControl->getComponent('unknown'));
-assertType('Nette\ComponentModel\IComponent|null', $someControl->getComponent('unknown', false));
-assertType('Nette\ComponentModel\IComponent', $someControl->getComponent('unknown', true));
+assertType('mixed~null', $someControl->getComponent('unknown'));
+assertType('mixed', $someControl->getComponent('unknown', false));
+assertType('mixed~null', $someControl->getComponent('unknown', true));
 
 $anotherControl = new AnotherControl();
 assertType('PHPStan\Type\Nette\Data\ComponentModel\AnotherControl', $anotherControl->getComponent('another'));
 assertType('PHPStan\Type\Nette\Data\ComponentModel\SomeControl', $anotherControl->getComponent('some'));
-assertType('Nette\ComponentModel\IComponent', $anotherControl->getComponent('unknown'));
-assertType('Nette\ComponentModel\IComponent|null', $anotherControl->getComponent('unknown', false));
-assertType('Nette\ComponentModel\IComponent', $anotherControl->getComponent('unknown', true));
+assertType('mixed~null', $anotherControl->getComponent('unknown'));
+assertType('mixed', $anotherControl->getComponent('unknown', false));
+assertType('mixed~null', $anotherControl->getComponent('unknown', true));
 
 $overrideCreateControl = new OverrideCreateControl();
 assertType('PHPStan\Type\Nette\Data\ComponentModel\AnotherControl', $overrideCreateControl->getComponent('some'));

tests/Type/Nette/data/componentModelArrayAccess.php

@@ -35,12 +35,12 @@ public function createComponent(string $name): AnotherControl {
 
 $someControl = new SomeControl();
 assertType('PHPStan\Type\Nette\Data\ComponentModelArrayAccess\SomeControl', $someControl['some']);
-assertType('Nette\ComponentModel\IComponent', $someControl['unknown']);
+assertType('mixed', $someControl['unknown']);
 
 $anotherControl = new AnotherControl();
 assertType('PHPStan\Type\Nette\Data\ComponentModelArrayAccess\AnotherControl', $anotherControl['another']);
 assertType('PHPStan\Type\Nette\Data\ComponentModelArrayAccess\SomeControl', $anotherControl['some']);
-assertType('Nette\ComponentModel\IComponent', $anotherControl['unknown']);
+assertType('mixed', $anotherControl['unknown']);
 
 $overrideCreateControl = new OverrideCreateControl();
 assertType('PHPStan\Type\Nette\Data\ComponentModelArrayAccess\AnotherControl', $overrideCreateControl['some']);