Skip to content

Commit a97717d

Browse files
arjendekortedevnexen
authored andcommitted
Fix GH-19021: deprecation for tidyOptIsReadOnly
The tidyOptGetCategory function (added in libtidy 5.4.0) if only useable if TidyInternalCategory (added in libtidy 5.6.0) is also present, so check for the latter instead. close GH-19053
1 parent 987a3a5 commit a97717d

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

NEWS

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ PHP NEWS
1717
- Standard:
1818
. Fixed bug GH-16649 (UAF during array_splice). (alexandre-daubois)
1919

20+
- Tidy:
21+
. Fixed GH-19021 build issue with libtidy in regard of tidyOptIsReadonly
22+
deprecation and TidyInternalCategory being available later than
23+
tidyOptGetCategory. (arjendekorte)
24+
2025
28 Aug 2025, PHP 8.3.25
2126

2227
- Core:

ext/tidy/config.m4

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ if test "$PHP_TIDY" != "no"; then
6262
AC_DEFINE(HAVE_TIDYRELEASEDATE,1,[ ])
6363
], [], [])
6464

65-
PHP_CHECK_LIBRARY($TIDY_LIB_NAME,tidyOptGetCategory,
65+
dnl The tidyOptGetCategory function (added in libtidy 5.4.0) if only useable
66+
dnl if TidyInternalCategory (added in libtidy 5.6.0) is also present.
67+
PHP_CHECK_LIBRARY($TIDY_LIB_NAME,TidyInternalCategory,
6668
[
6769
AC_DEFINE(HAVE_TIDYOPTGETCATEGORY,1,[ ])
6870
], [], [])

0 commit comments

Comments
 (0)