From fb0e3fe0880d06cd67d108964f31c393c058a18c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20D=C3=BCsterhus?= <tim@tideways-gmbh.com>
Date: Tue, 22 Oct 2024 14:40:02 +0200
Subject: [PATCH 1/2] Document `ReflectionClassConstant::isDeprecated()`

---
 .../reflectionclassconstant/isdeprecated.xml  | 94 +++++++++++++++++++
 reference/reflection/versions.xml             |  1 +
 2 files changed, 95 insertions(+)
 create mode 100644 reference/reflection/reflectionclassconstant/isdeprecated.xml

diff --git a/reference/reflection/reflectionclassconstant/isdeprecated.xml b/reference/reflection/reflectionclassconstant/isdeprecated.xml
new file mode 100644
index 000000000000..264e6fb2207d
--- /dev/null
+++ b/reference/reflection/reflectionclassconstant/isdeprecated.xml
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- $Revision$ -->
+<refentry xml:id="reflectionclassconstant.isdeprecated" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <refnamediv>
+  <refname>ReflectionClassConstant::isDeprecated</refname>
+  <refpurpose>Checks if deprecated</refpurpose>
+ </refnamediv>
+
+ <refsect1 role="description">
+  &reftitle.description;
+  <methodsynopsis role="ReflectionClassConstant">
+   <modifier>public</modifier> <type>bool</type><methodname>ReflectionClassConstant::isDeprecated</methodname>
+   <void/>
+  </methodsynopsis>
+  <para>
+   Checks whether the class constant is deprecated.
+  </para>
+
+ </refsect1>
+
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
+ <refsect1 role="returnvalues">
+  &reftitle.returnvalues;
+  <para>
+   &true; if it's deprecated, otherwise &false;
+  </para>
+ </refsect1>
+
+ <refsect1 role="examples">
+  &reftitle.examples;
+  <para>
+   <example>
+    <title>
+     <methodname>ReflectionClassConstant::isDeprecated</methodname> example
+    </title>
+    <programlisting role="php">
+<![CDATA[
+<?php
+class Basket {
+    #[\Deprecated(message: 'use Basket::APPLE instead')]
+    public const APLE = 'apple';
+
+    public const APPLE = 'apple';
+}
+$classConstant = new ReflectionClassConstant('Basket', 'APLE');
+var_dump($classConstant->isDeprecated());
+?>
+]]>
+    </programlisting>
+    &example.outputs;
+    <screen>
+<![CDATA[
+bool(true)
+]]>
+    </screen>
+   </example>
+  </para>
+ </refsect1>
+
+ <refsect1 role="seealso">
+  &reftitle.seealso;
+  <para>
+   <simplelist>
+    <member><classname>Deprecated</classname></member>
+    <member><methodname>ReflectionClassConstant::getDocComment</methodname></member>
+   </simplelist>
+  </para>
+ </refsect1>
+
+</refentry>
+<!-- Keep this comment at the end of the file
+Local variables:
+mode: sgml
+sgml-omittag:t
+sgml-shorttag:t
+sgml-minimize-attributes:nil
+sgml-always-quote-attributes:t
+sgml-indent-step:1
+sgml-indent-data:t
+indent-tabs-mode:nil
+sgml-parent-document:nil
+sgml-default-dtd-file:"~/.phpdoc/manual.ced"
+sgml-exposed-tags:nil
+sgml-local-catalogs:nil
+sgml-local-ecat-files:nil
+End:
+vim600: syn=xml fen fdm=syntax fdl=2 si
+vim: et tw=78 syn=sgml
+vi: ts=1 sw=1
+-->
diff --git a/reference/reflection/versions.xml b/reference/reflection/versions.xml
index c9306527d28e..ad96fa88cc28 100644
--- a/reference/reflection/versions.xml
+++ b/reference/reflection/versions.xml
@@ -268,6 +268,7 @@
  <function name="reflectionclassconstant::__tostring" from="PHP 7 &gt;= 7.1.0, PHP 8"/>
  <function name="reflectionclassconstant::export" from="PHP 7 &gt;= 7.1.0" deprecated="PHP 7.4.0" removed="PHP 8"/>
  <function name="reflectionclassconstant::getname" from="PHP 7 &gt;= 7.1.0, PHP 8"/>
+ <function name="reflectionclassconstant::isdeprecated" from="PHP 8 &gt;= 8.4.0"/>
  <function name="reflectionclassconstant::isenumcase" from="PHP 8 &gt;= 8.1.0"/>
  <function name="reflectionclassconstant::isfinal" from="PHP 8 &gt;= 8.1.0"/>
  <function name="reflectionclassconstant::ispublic" from="PHP 7 &gt;= 7.1.0, PHP 8"/>

From b605b13060eaf3c23a1b9dfbeec388178f2898d0 Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Tue, 12 Nov 2024 14:24:50 +0000
Subject: [PATCH 2/2] Review

---
 .../reflectionclassconstant/isdeprecated.xml  | 40 +++++++++----------
 1 file changed, 18 insertions(+), 22 deletions(-)

diff --git a/reference/reflection/reflectionclassconstant/isdeprecated.xml b/reference/reflection/reflectionclassconstant/isdeprecated.xml
index 264e6fb2207d..0fa5d36cb186 100644
--- a/reference/reflection/reflectionclassconstant/isdeprecated.xml
+++ b/reference/reflection/reflectionclassconstant/isdeprecated.xml
@@ -12,9 +12,9 @@
    <modifier>public</modifier> <type>bool</type><methodname>ReflectionClassConstant::isDeprecated</methodname>
    <void/>
   </methodsynopsis>
-  <para>
+  <simpara>
    Checks whether the class constant is deprecated.
-  </para>
+  </simpara>
 
  </refsect1>
 
@@ -25,19 +25,18 @@
 
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
-  <para>
+  <simpara>
    &true; if it's deprecated, otherwise &false;
-  </para>
+  </simpara>
  </refsect1>
 
  <refsect1 role="examples">
   &reftitle.examples;
-  <para>
-   <example>
-    <title>
-     <methodname>ReflectionClassConstant::isDeprecated</methodname> example
-    </title>
-    <programlisting role="php">
+  <example>
+   <title>
+    <methodname>ReflectionClassConstant::isDeprecated</methodname> example
+   </title>
+   <programlisting role="php">
 <![CDATA[
 <?php
 class Basket {
@@ -50,25 +49,22 @@ $classConstant = new ReflectionClassConstant('Basket', 'APLE');
 var_dump($classConstant->isDeprecated());
 ?>
 ]]>
-    </programlisting>
-    &example.outputs;
-    <screen>
+   </programlisting>
+   &example.outputs;
+   <screen>
 <![CDATA[
 bool(true)
 ]]>
-    </screen>
-   </example>
-  </para>
+   </screen>
+  </example>
  </refsect1>
 
  <refsect1 role="seealso">
   &reftitle.seealso;
-  <para>
-   <simplelist>
-    <member><classname>Deprecated</classname></member>
-    <member><methodname>ReflectionClassConstant::getDocComment</methodname></member>
-   </simplelist>
-  </para>
+  <simplelist>
+   <member><classname>Deprecated</classname></member>
+   <member><methodname>ReflectionClassConstant::getDocComment</methodname></member>
+  </simplelist>
  </refsect1>
 
 </refentry>