refactor inlining code and add tests for it#987

Merged

guillep merged 24 commits intopharo-project:pharo-12from

RenaudFondeur:betterInliningStable

Jul 18, 2025

Commits on Jul 18, 2025

refactor of inlining to its own class

RenaudFondeur
authored and
guillep
committed
refactor duplicated code

RenaudFondeur
authored and
guillep
committed
refactor code

RenaudFondeur
authored and
guillep
committed
refactor to supress unused arguments

RenaudFondeur
authored and
guillep
committed
fix the visitor

RenaudFondeur
authored and
guillep
committed
fix broken test + clean infos of visitor when no longer needed

RenaudFondeur
authored and
guillep
committed
add test for returning node as expression handle with an old potentially buggy hack

RenaudFondeur
authored and
guillep
committed
remove halt in test

RenaudFondeur
authored and
guillep
committed
add a strategy pattern for using inlining

RenaudFondeur
authored and
guillep
committed
revert change to old method

RenaudFondeur
authored and
guillep
committed
remove conditional check in copyWithoutReturn

RenaudFondeur
authored and
guillep
committed
small change to the visitor

RenaudFondeur
authored and
guillep
committed
fix bug + cleaning

RenaudFondeur
authored and
guillep
committed
cleaning + fix a bug with multiple return in a returning inlined expression

RenaudFondeur
authored and
guillep
committed
better tests

RenaudFondeur
authored and
guillep
committed
start of revert to stable

RenaudFondeur
authored and
guillep
committed
no use of the visitor in new strategy

RenaudFondeur
authored and
guillep
committed
clean the code

RenaudFondeur
authored and
guillep
committed
add tests for bugs

Renaud
authored and
guillep
committed
change little things to clean the pr

RenaudFondeur
authored and
guillep
committed
restore previous addAllLast handling comments in its own methods ans restore the tests for it

RenaudFondeur
authored and
guillep
committed
revert (but without the unecessary returnNode) to incorrect but stable bug with the non-necessary nil

RenaudFondeur
authored and
guillep
committed
Apply suggestions from code review
guillep
committed
suppress failing tests

RenaudFondeur
authored and
guillep
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor inlining code and add tests for it#987

refactor inlining code and add tests for it#987
guillep merged 24 commits intopharo-project:pharo-12from
RenaudFondeur:betterInliningStable

Commits on Jul 18, 2025

refactor of inlining to its own class

refactor duplicated code

refactor code

refactor to supress unused arguments

fix the visitor

fix broken test + clean infos of visitor when no longer needed

add test for returning node as expression handle with an old potentially buggy hack

remove halt in test

add a strategy pattern for using inlining

revert change to old method

remove conditional check in copyWithoutReturn

small change to the visitor

fix bug + cleaning

cleaning + fix a bug with multiple return in a returning inlined expression

better tests

start of revert to stable

no use of the visitor in new strategy

clean the code

add tests for bugs

change little things to clean the pr

restore previous addAllLast handling comments in its own methods ans restore the tests for it

revert (but without the unecessary returnNode) to incorrect but stable bug with the non-necessary nil

Apply suggestions from code review

suppress failing tests

refactor inlining code and add tests for it#987guillep merged 24 commits intopharo-project:pharo-12pharo-project/pharo-vm:pharo-12from RenaudFondeur:betterInliningStableRenaudFondeur/pharo-vm:betterInliningStableCopy head branch name to clipboard

Commits

Commits on Jul 18, 2025

refactor inlining code and add tests for it#987
guillep merged 24 commits intopharo-project:pharo-12from
RenaudFondeur:betterInliningStable