Ng-Docs: Moved 'card' examples out of TrendChart and UtilizationBarChart... #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art, and into base Card
Member
Author
|
@rhamilto, @jeff-phillips-18 if these changes are ok with you guys, please merge. -thanks |
Member
|
LGTM |
Member
There was a problem hiding this comment.
The label element is intended for use in forms. This would be better as a heading (e.g., h2).
Member
Author
There was a problem hiding this comment.
There is an issue/bug in ng-docs which we haven't gotten to the root of yet. When I used H's, they get converted to H6's and render strangely.
jeff-phillips-18
added a commit
that referenced
this pull request
Nov 9, 2015
Ng-Docs: Moved 'card' examples out of TrendChart and UtilizationBarChart...
Member
Author
|
Sorry, Jeff merged while you were commenting. I will add a JIRA bug to track the ngdoc H issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and into base Card.
Updated pfCard examples:
Updated Utilization Bar Chart examples: