fix: actually create stream in query mode if not present in memory

Author: Devdutt Shenoi

src/handlers/http/logstream.rs

@@ -49,13 +49,10 @@ pub async fn delete(stream_name: Path<String>) -> Result<impl Responder, StreamE
     let stream_name = stream_name.into_inner();
     // Error out if stream doesn't exist in memory, or in the case of query node, in storage as well
     if !PARSEABLE.streams.contains(&stream_name)
-        && PARSEABLE.options.mode == Mode::Query
-        && matches!(
-            PARSEABLE
+        && (PARSEABLE.options.mode != Mode::Query
+            || !PARSEABLE
                 .create_stream_and_schema_from_storage(&stream_name)
-                .await,
-            Ok(true) | Err(_)
-        )
+                .await?)
     {
         return Err(StreamNotFound(stream_name).into());
     }
@@ -133,10 +130,11 @@ pub async fn get_schema(stream_name: Path<String>) -> Result<impl Responder, Str
     let stream_name = stream_name.into_inner();
 
     // Ensure parseable is aware of stream in distributed mode
-    if PARSEABLE.options.mode == Mode::Query
-        && !PARSEABLE
-            .create_stream_and_schema_from_storage(&stream_name)
-            .await?
+    if !PARSEABLE.streams.contains(&stream_name)
+        && (PARSEABLE.options.mode != Mode::Query
+            || !PARSEABLE
+                .create_stream_and_schema_from_storage(&stream_name)
+                .await?)
     {
         return Err(StreamNotFound(stream_name.clone()).into());
     }
@@ -173,10 +171,11 @@ pub async fn get_retention(stream_name: Path<String>) -> Result<impl Responder,
     // For query mode, if the stream not found in memory map,
     //check if it exists in the storage
     //create stream and schema from storage
-    if PARSEABLE.options.mode == Mode::Query
-        && !PARSEABLE
-            .create_stream_and_schema_from_storage(&stream_name)
-            .await?
+    if !PARSEABLE.streams.contains(&stream_name)
+        && (PARSEABLE.options.mode != Mode::Query
+            || !PARSEABLE
+                .create_stream_and_schema_from_storage(&stream_name)
+                .await?)
     {
         return Err(StreamNotFound(stream_name.clone()).into());
     }
@@ -197,10 +196,11 @@ pub async fn put_retention(
     // For query mode, if the stream not found in memory map,
     //check if it exists in the storage
     //create stream and schema from storage
-    if PARSEABLE.options.mode == Mode::Query
-        && !PARSEABLE
-            .create_stream_and_schema_from_storage(&stream_name)
-            .await?
+    if !PARSEABLE.streams.contains(&stream_name)
+        && (PARSEABLE.options.mode != Mode::Query
+            || !PARSEABLE
+                .create_stream_and_schema_from_storage(&stream_name)
+                .await?)
     {
         return Err(StreamNotFound(stream_name).into());
     }
@@ -410,10 +410,11 @@ pub async fn put_stream_hot_tier(
     // For query mode, if the stream not found in memory map,
     //check if it exists in the storage
     //create stream and schema from storage
-    if PARSEABLE.options.mode == Mode::Query
-        && !PARSEABLE
-            .create_stream_and_schema_from_storage(&stream_name)
-            .await?
+    if !PARSEABLE.streams.contains(&stream_name)
+        && (PARSEABLE.options.mode != Mode::Query
+            || !PARSEABLE
+                .create_stream_and_schema_from_storage(&stream_name)
+                .await?)
     {
         return Err(StreamNotFound(stream_name).into());
     }
@@ -486,10 +487,11 @@ pub async fn delete_stream_hot_tier(
     // For query mode, if the stream not found in memory map,
     //check if it exists in the storage
     //create stream and schema from storage
-    if PARSEABLE.options.mode == Mode::Query
-        && !PARSEABLE
-            .create_stream_and_schema_from_storage(&stream_name)
-            .await?
+    if !PARSEABLE.streams.contains(&stream_name)
+        && (PARSEABLE.options.mode != Mode::Query
+            || !PARSEABLE
+                .create_stream_and_schema_from_storage(&stream_name)
+                .await?)
     {
         return Err(StreamNotFound(stream_name).into());
     }