reduce stack allocated buffered size to render this crate constrained system friendly

Author: ithinuel

Cargo.toml

@@ -20,6 +20,8 @@ time = "0.1"
 default = ["std"]
 std = []
 
+reduced-stack-buffer = []
+
 #
 # Features for enabling non-MVP proposals.
 # These features should be tested as part of Travis CI build.

src/elements/primitives.rs

@@ -2,6 +2,13 @@ use alloc::{string::String, vec::Vec};
 use crate::{io, elements};
 use super::{Error, Deserialize, Serialize};
 
+
+#[cfg(feature = "reduced-stack-buffer")]
+const PRIMITIVES_BUFFER_LENGTH: usize = 256;
+
+#[cfg(not(feature = "reduced-stack-buffer"))]
+const PRIMITIVES_BUFFER_LENGTH: usize = 1024;
+
 /// Unsigned variable-length integer, limited to 32 bits,
 /// represented by at most 5 bytes that may contain padding 0x80 bytes.
 #[derive(Debug, Copy, Clone, PartialEq)]
@@ -520,7 +527,7 @@ impl Deserialize for String {
 	fn deserialize<R: io::Read>(reader: &mut R) -> Result<Self, Self::Error> {
 		let length = u32::from(VarUint32::deserialize(reader)?) as usize;
 		if length > 0 {
-			String::from_utf8(buffered_read!(1024, length, reader)).map_err(|_| Error::NonUtf8String)
+			String::from_utf8(buffered_read!(PRIMITIVES_BUFFER_LENGTH, length, reader)).map_err(|_| Error::NonUtf8String)
 		}
 		else {
 			Ok(String::new())

src/elements/section.rs

@@ -26,6 +26,10 @@ use super::types::Type;
 use super::name_section::NameSection;
 use super::reloc_section::RelocSection;
 
+#[cfg(feature = "reduced-stack-buffer")]
+const ENTRIES_BUFFER_LENGTH: usize = 256;
+
+#[cfg(not(feature = "reduced-stack-buffer"))]
 const ENTRIES_BUFFER_LENGTH: usize = 16384;
 
 /// Section in the WebAssembly module.
@@ -331,7 +335,7 @@ impl Deserialize for CustomSection {
 
 	fn deserialize<R: io::Read>(reader: &mut R) -> Result<Self, Self::Error> {
 		let section_length: usize = u32::from(VarUint32::deserialize(reader)?) as usize;
-		let buf = buffered_read!(16384, section_length, reader);
+		let buf = buffered_read!(ENTRIES_BUFFER_LENGTH, section_length, reader);
 		let mut cursor = io::Cursor::new(&buf[..]);
 		let name = String::deserialize(&mut cursor)?;
 		let payload = buf[cursor.position() as usize..].to_vec();

src/elements/segment.rs

@@ -9,6 +9,12 @@ const FLAG_PASSIVE: u32 = 1;
 #[cfg(feature="bulk")]
 const FLAG_MEM_NONZERO: u32 = 2;
 
+#[cfg(feature = "reduced-stack-buffer")]
+const VALUES_BUFFER_LENGTH: usize = 256;
+
+#[cfg(not(feature = "reduced-stack-buffer"))]
+const VALUES_BUFFER_LENGTH: usize = 16384;
+
 /// Entry in the element section.
 #[derive(Debug, Clone, PartialEq)]
 pub struct ElementSegment {
@@ -217,7 +223,7 @@ impl Deserialize for DataSegment {
 		let index = VarUint32::deserialize(reader)?;
 		let offset = InitExpr::deserialize(reader)?;
 		let value_len = u32::from(VarUint32::deserialize(reader)?) as usize;
-		let value_buf = buffered_read!(65536, value_len, reader);
+		let value_buf = buffered_read!(VALUES_BUFFER_LENGTH, value_len, reader);
 
 		Ok(DataSegment {
 			index: index.into(),
@@ -242,7 +248,7 @@ impl Deserialize for DataSegment {
 			Some(InitExpr::deserialize(reader)?)
 		};
 		let value_len = u32::from(VarUint32::deserialize(reader)?) as usize;
-		let value_buf = buffered_read!(65536, value_len, reader);
+		let value_buf = buffered_read!(VALUES_BUFFER_LENGTH, value_len, reader);
 
 		Ok(DataSegment {
 			index: index,