Skip to content

Commit b1868c2

Browse files
authored
unsafe log unknown remote exception body (#563)
add the body of the UnknownRemoteException as a unsafe parameter
1 parent f8dc128 commit b1868c2

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
type: improvement
2+
improvement:
3+
description: add the body of the UnknownRemoteException as a unsafe parameter
4+
links:
5+
- https://github.com/palantir/conjure-java-runtime-api/pull/563

errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
import com.palantir.logsafe.Arg;
2020
import com.palantir.logsafe.SafeArg;
2121
import com.palantir.logsafe.SafeLoggable;
22+
import com.palantir.logsafe.UnsafeArg;
23+
import java.util.ArrayList;
2224
import java.util.Collections;
2325
import java.util.List;
2426

@@ -52,6 +54,9 @@ public String getLogMessage() {
5254

5355
@Override
5456
public List<Arg<?>> getArgs() {
55-
return Collections.singletonList(SafeArg.of("status", getStatus()));
57+
List<Arg<?>> args = new ArrayList<>(2);
58+
args.add(SafeArg.of("status", getStatus()));
59+
args.add(UnsafeArg.of("body", getBody()));
60+
return Collections.unmodifiableList(args);
5661
}
5762
}

errors/src/test/java/com/palantir/conjure/java/api/errors/UnknownRemoteExceptionTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import static org.assertj.core.api.Assertions.assertThat;
2020

2121
import com.palantir.logsafe.SafeArg;
22+
import com.palantir.logsafe.UnsafeArg;
2223
import org.junit.jupiter.api.Test;
2324

2425
class UnknownRemoteExceptionTest {
@@ -34,6 +35,6 @@ public void testMessage() {
3435
@Test
3536
public void testArgsContainsStatus() {
3637
UnknownRemoteException exception = new UnknownRemoteException(404, "not found");
37-
assertThat(exception.getArgs()).containsOnly(SafeArg.of("status", 404));
38+
assertThat(exception.getArgs()).containsExactly(SafeArg.of("status", 404), UnsafeArg.of("body", "not found"));
3839
}
3940
}

0 commit comments

Comments
 (0)