Fix a controlled EditableText bug #3742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where EditableText controlled value cannot be reset to undefined or null. The comments in this file state that the point of mirroring the `props.value` to `state.value` is to maintain that value while the user is editing. However, if the user is not editing, the edited line in question as is does not allow for the value of the component to be reset to something undefined or null for emptiness.
Member
|
Thanks for your interest in palantir/blueprint, @chiubaka! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Contributor
|
You're failing a unit test:
I think you'll need to abstract the logic for getting the value from In addition, can you please add a unit test for this behavior change? |
Contributor
|
superseded by #3924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where EditableText controlled value cannot be reset to undefined or null.
The comments in this file state that the point of mirroring the
props.valuetostate.valueis to maintain that value while the useris editing. However, if the user is not editing, the edited line in question as is does not allow for the value of the component to be
reset to something undefined or null for emptiness.
Fixes #0000
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot