From 4b304e3e3598eae614ef31f2ca43a3523c8aa5c2 Mon Sep 17 00:00:00 2001 From: Rootul Patel Date: Thu, 10 Jan 2019 12:00:01 -0800 Subject: [PATCH] Popover docs: inline -> usePortal={false} I _think_ inline is outdated b/c I don't see docs on that prop above. I'm pretty sure this section means to reference `usePortal={false}` instead. --- packages/core/src/components/popover/popover.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/src/components/popover/popover.md b/packages/core/src/components/popover/popover.md index c43989d139b..b4050ef5fd7 100644 --- a/packages/core/src/components/popover/popover.md +++ b/packages/core/src/components/popover/popover.md @@ -397,12 +397,12 @@ documentation. #### Animation delays `Popover` can be difficult to test because it uses `Portal` to inject its contents elsewhere in the -DOM (outside the usual flow); this can be simplified by using `inline` Popovers in tests. +DOM (outside the usual flow); this can be simplified by setting `usePortal={false}` in tests. Hover interactions can also be tricky due to delays and transitions; this can be resolved by zeroing the default hover delays. ```tsx - + {yourTarget} ``` @@ -439,7 +439,7 @@ setTimeout(() => { #### Element refs -If `inline` rendering is not an option, `Popover` instances expose `popoverElement` and +If `usePortal={false}` rendering is not an option, `Popover` instances expose `popoverElement` and `targetElement` refs of the actual DOM elements. Importantly, `popoverElement` points to the `.@ns-popover` element inside the `Portal` so you can use it to easily query popover contents without knowing precisely where they are in the DOM. These properties exist primarily to simplify testing;