Skip to content

Commit 78f6502

Browse files
authored
[datetime] fix(DateRange): values are possibly null, not undefi… (#3983)
fixes #3970
1 parent fddba2c commit 78f6502

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/datetime/src/common/dateUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import { Months } from "./months";
1818

19-
export type DateRange = [Date | undefined, Date | undefined];
19+
export type DateRange = [Date | null, Date | null];
2020

2121
export function isDateValid(date: Date | false | null): date is Date {
2222
return date instanceof Date && !isNaN(date.valueOf());

packages/datetime/src/dateRangePicker.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,8 @@ export class DateRangePicker extends AbstractPureComponent2<IDateRangePickerProp
347347
}
348348

349349
private handleTimeChange = (newTime: Date, dateIndex: number) => {
350-
Utils.safeInvoke(this.props.timePickerProps.onChange, newTime);
350+
this.props.timePickerProps?.onChange?.(newTime);
351+
351352
const { value, time } = this.state;
352353
const newValue = DateUtils.getDateTime(
353354
value[dateIndex] != null ? DateUtils.clone(value[dateIndex]) : new Date(),
@@ -357,7 +358,7 @@ export class DateRangePicker extends AbstractPureComponent2<IDateRangePickerProp
357358
newDateRange[dateIndex] = newValue;
358359
const newTimeRange: DateRange = [time[0], time[1]];
359360
newTimeRange[dateIndex] = newTime;
360-
Utils.safeInvoke(this.props.onChange, newDateRange);
361+
this.props.onChange?.(newDateRange);
361362
this.setState({ value: newDateRange, time: newTimeRange });
362363
};
363364

0 commit comments

Comments
 (0)