[external API] alerts: the renamening (#8169)

In conversation with @ahl, we have determined that the external API for
webhooks added in #7277 should be changed to focus on "alerts" as the
first-class user-facing concept, with "webhooks" as one delivery
mechanism for alerts. This way, we can talk about alerts as an entity in
the API that exist independently of webhooks that deliver alerts, and
the same alert types can be shared with other alert delivery mechanisms
if any are added in the future.

What we currently refer to as "webhook events" and "webhook event
classes" are therefore renamed to "alerts" and "alert classes". The
current concept of "webhook receivers" is generalized to an "alert
receiver" resource, of which webhook receivers are (currently) the only
subtype. This way, if we add other mechanisms of delivering alerts in
the future (email, first-class Slack integration, etc), we can introduce
new subtypes of alert receivers. I've restructured the API to have both
`/v1/alert-receivers/...` and `/v1/webhook-receivers/...` routes, with
operations common to all alert receivers (list, view, add/remove
subscriptions, delete) under the `alert-receivers` route, and operations
related to webhook-specific configuration (add/remove secrets, probe,
deliveries) under the `webhook-receivers` route. I've also changed the
`AlertReceiver` view to have a "kind" enum that stores the
subtype-specific configuration; currently, this will only ever be
"webhook", but I thought it was worth doing this now to make future
additions cause less breakage for API consumers.

This is, admittedly, a somewhat large diff, but fortunately, most of it
is just renaming stuff and moving it around. Reviewers can focus more or
less exclusively to the changes to the external API routes and models,
and maybe the database migrations. Any mistakes while renaming and
moving things around have already been caught by the Rust compiler. :)

Author: hawkw

common/src/api/external/mod.rs

@@ -977,6 +977,8 @@ pub enum ResourceType {
     AffinityGroupMember,
     AntiAffinityGroup,
     AntiAffinityGroupMember,
+    Alert,
+    AlertReceiver,
     AllowList,
     BackgroundTask,
     BgpConfig,
@@ -1040,8 +1042,6 @@ pub enum ResourceType {
     Probe,
     ProbeNetworkInterface,
     LldpLinkConfig,
-    WebhookEvent,
-    WebhookReceiver,
     WebhookSecret,
 }
 

dev-tools/omdb/src/bin/omdb/db.rs

@@ -23,6 +23,7 @@ use crate::helpers::CONNECTION_OPTIONS_HEADING;
 use crate::helpers::DATABASE_OPTIONS_HEADING;
 use crate::helpers::const_max_len;
 use crate::helpers::display_option_blank;
+use alert::AlertArgs;
 use anyhow::Context;
 use anyhow::anyhow;
 use anyhow::bail;
@@ -169,11 +170,9 @@ use std::sync::Arc;
 use strum::IntoEnumIterator;
 use tabled::Tabled;
 use uuid::Uuid;
-use webhook::WebhookArgs;
-use webhook::cmd_db_webhook;
 
+mod alert;
 mod saga;
-mod webhook;
 
 const NO_ACTIVE_PROPOLIS_MSG: &str = "<no active Propolis>";
 const NOT_ON_SLED_MSG: &str = "<not on any sled>";
@@ -387,8 +386,8 @@ enum DbCommands {
     Vmms(VmmListArgs),
     /// Print information about the oximeter collector.
     Oximeter(OximeterArgs),
-    /// Print information about webhooks
-    Webhook(WebhookArgs),
+    /// Print information about alerts
+    Alert(AlertArgs),
     /// Commands for querying and interacting with pools
     Zpool(ZpoolArgs),
 }
@@ -1467,7 +1466,7 @@ impl DbArgs {
                         command: OximeterCommands::ListProducers
                     }) => cmd_db_oximeter_list_producers(&datastore, fetch_opts).await,
 
-                    DbCommands::Webhook(args) => cmd_db_webhook(&opctx, &datastore, &fetch_opts, &args).await,
+                    DbCommands::Alert(args) => alert::cmd_db_alert(&opctx, &datastore, &fetch_opts, &args).await,
                     DbCommands::Zpool(ZpoolArgs {
                         command: ZpoolCommands::List(args)
                     }) => cmd_db_zpool_list(&opctx, &datastore, &args).await,