chore: get rid of usePrefetchedApiQuery, apiQueryClient, and useApiQueryClient
#2967
+517
−698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big but mechanical refactor I've been putting off forever. The point is to delete the helpers deleted in
app/api/hooks.ts. I have another smaller change following this that will simplify the types in the remaining helpers, which have been my nemesis for 5 years.The broader idea is to rely on the
QueryOptionsAPI from React Query, which we can generate for our API calls in type-safe ways, producing a uniform object that can be passed equally well to any of the built-in RQ functions likeuseQueryandqueryClient.prefetchQuery, which means we can share the query options between the loader prefetch and the fetch inside the component.