Skip to content

Remove legacy deposit/withdrawal in Electra #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

Remove legacy deposit/withdrawal in Electra #22

wants to merge 18 commits into from

Conversation

@qqqeck
Copy link
Contributor

@qqqeck qqqeck commented Oct 28, 2024 •
edited
Loading

Remove legacy deposit/withdrawal from Electra

  • remove legacy fields(eth1data, deposit, bls_to_execution) from electra block
  • remove unused fiels from electra state
  • disable powchain
  • remove index field from deposit_request ( should be handled together w/ geth )
  • fix tests

Temporarily commented out tests

  • TestProcessDeposit_SkipsInvalidDeposit
  • TestVerifyOperationLengths_Electra
  • TestProposer_PendingDeposits_Electra

@qqqeck qqqeck requested a review from a team as a code owner October 28, 2024 03:57
@syjn99 syjn99 added the alpaca Road to alpaca spec label Oct 28, 2024
gazzua
gazzua reviewed Oct 31, 2024
View reviewed changes
1
@@ -0,0 +1,130 @@
# Enable Powerlevel10k instant prompt. Should stay close to the top of ~/.zshrc.
Copy link
Contributor

@gazzua gazzua Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you committed wrong file 😄

gazzua
gazzua reviewed Oct 31, 2024
View reviewed changes
proto/prysm/v1alpha1/sync_committee.pb.go
@@ -0,0 +1,487 @@
// Code generated by protoc-gen-go. DO NOT EDIT.
Copy link
Contributor

@gazzua gazzua Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

committed wrong file 😄

gazzua
gazzua reviewed Oct 31, 2024
View reviewed changes
proto/eth/v2/sync_committee.pb.go
@@ -0,0 +1,340 @@
// Code generated by protoc-gen-go. DO NOT EDIT.
Copy link
Contributor

@gazzua gazzua Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

committed wrong file. sync committee is deleted in other pr

@gazzua
Copy link
Contributor

gazzua commented Oct 31, 2024

add state version check would be better at state-native/setters-eth1.go and state-native/getters-eth1.go

if b.version >= version.Electra {
   return errNotSupported("Eth1Data", b.version)
}

gazzua
gazzua reviewed Oct 31, 2024
View reviewed changes
beacon-chain/state/state-native/beacon_state.go

// Electra fields
depositRequestsStartIndex uint64
depositBalanceToConsume primitives.Gwei
Copy link
Contributor

@gazzua gazzua Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DepositRequestsStartIndex in beaconStateMarshalable should also be removed.

@qqqeck
Copy link
Contributor Author

qqqeck commented Oct 31, 2024

Closed due to a change of plan

@qqqeck qqqeck closed this Oct 31, 2024
@qqqeck qqqeck deleted the feature/disable_eth1vote branch November 26, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gazzua gazzua gazzua left review comments

Assignees

@qqqeck qqqeck

Labels

alpaca Road to alpaca spec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qqqeck @gazzua @syjn99