Skip to content

Commit c98def0

Browse files
committed
Replace run_once: _oraswgi_meta_configure_cluster with when condition
The execution of some roles on multiple hosts was not possivle, because some tasks had run_once to limit the execution on 1 node in RAC environments only. This does NOT enable the installation of multiple RAC cluster in 1 playbook run.
1 parent f341e40 commit c98def0

File tree

32 files changed

+293
-191
lines changed

32 files changed

+293
-191
lines changed

changelogs/fragments/run_once.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
---
2+
minor_changes:
3+
- "Replace run_once: _oraswgi_meta_configure_cluster with when condition ()"

roles/oradb_manage_db/tasks/manage-db.yml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,9 @@
9090
# loop_var dbh was replaced by odb in outer loop
9191
# => no need to change all dbca-templates...
9292
dbh: "{{ odb }}"
93-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
94-
when: odb.state == 'present'
93+
when:
94+
- odb.state == 'present'
95+
- _orasw_meta_primary_node | bool
9596
tags:
9697
- create_db
9798
- dbcatemplate
@@ -125,10 +126,11 @@
125126
initparams: "{{ _oradb_manage_db_init_params_list | default(omit) }}"
126127
output: verbose
127128
state: "{{ odb.state }}"
128-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
129129
become: true
130130
become_user: "{{ oracle_user }}"
131-
when: odb.state == 'present'
131+
when:
132+
- odb.state == 'present'
133+
- _orasw_meta_primary_node | bool
132134
register: dbca_create
133135

134136
rescue:
@@ -159,8 +161,9 @@
159161

160162
- ansible.builtin.debug:
161163
msg: "Removing DB - {{ odb.oracle_db_name }}, ORACLE_HOME - {{ _oracle_home_db }}" # noqa name[missing]
162-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
163-
when: odb.state == 'absent'
164+
when:
165+
- odb.state == 'absent'
166+
- _orasw_meta_primary_node | bool
164167

165168
- name: manage_db | remove database
166169
opitzconsulting.ansible_oracle.oracle_db:
@@ -171,10 +174,11 @@
171174
db_name: "{{ odb.oracle_db_name }}"
172175
output: verbose
173176
state: "{{ odb.state }}"
174-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
175177
become: true
176178
become_user: "{{ oracle_user }}"
177-
when: odb.state == 'absent'
179+
when:
180+
- odb.state == 'absent'
181+
- _orasw_meta_primary_node | bool
178182
register: dbca_remove
179183
tags: remove_db,dbca
180184

roles/oradb_manage_grants/tasks/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
skip_missing: true
2222
environment: "{{ _oracle_env_cdb }}"
2323
when:
24+
- _orasw_meta_primary_node | bool
2425
- oracle_databases is defined
2526
- odb.0.state == 'present'
2627
- oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
2728
- (odb.1.grants is defined or odb.1.object_privs is defined)
28-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
2929
become: true
3030
become_user: "{{ oracle_user }}"
3131
loop_control:
@@ -62,6 +62,7 @@
6262
skip_missing: true
6363
environment: "{{ _oracle_env_pdb }}"
6464
when:
65+
- _orasw_meta_primary_node | bool
6566
- oracle_pdbs is defined
6667
- opdb.0 is defined
6768
- opdb.0.state == 'present'
@@ -70,7 +71,6 @@
7071
- >-
7172
oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
7273
| map(attribute='state') | list | first == 'present'
73-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
7474
become: true
7575
become_user: "{{ oracle_user }}"
7676
loop_control:
@@ -110,11 +110,11 @@
110110
skip_missing: true
111111
environment: "{{ _oracle_env }}"
112112
when:
113+
- _orasw_meta_primary_node | bool
113114
- oracle_databases is defined
114115
- odb.0.state == 'present'
115116
- oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
116117
- (odb.1.grants is defined or odb.1.object_privs is defined)
117-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
118118
become: true
119119
become_user: "{{ oracle_user }}"
120120
loop_control:
@@ -151,6 +151,7 @@
151151
skip_missing: true
152152
environment: "{{ _oracle_env_pdb }}"
153153
when:
154+
- _orasw_meta_primary_node | bool
154155
- oracle_pdbs is defined
155156
- opdb.0 is defined
156157
- opdb.0.state == 'present'
@@ -159,7 +160,6 @@
159160
- >-
160161
oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
161162
| map(attribute='state') | list | first == 'present'
162-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
163163
become: true
164164
become_user: "{{ oracle_user }}"
165165
loop_control:

roles/oradb_manage_parameters/tasks/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414
state: "{{ odb.1.state }}"
1515
scope: "{{ odb.1.scope | default ('both') }}"
1616
environment: "{{ _oracle_env }}"
17-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
1817
with_subelements:
1918
- "{{ oracle_databases }}"
2019
- init_parameters
2120
- flags:
2221
skip_missing: true
2322
when:
23+
- _orasw_meta_primary_node | bool
2424
- oracle_databases is defined
2525
- odb.0.state == 'present'
2626
- oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
@@ -57,13 +57,13 @@
5757
state: "{{ opdb.1.state }}"
5858
scope: "{{ opdb.1.scope | default ('both') }}"
5959
environment: "{{ _oracle_env_pdb }}"
60-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
6160
with_subelements:
6261
- "{{ oracle_pdbs }}"
6362
- init_parameters
6463
- flags:
6564
skip_missing: true
6665
when:
66+
- _orasw_meta_primary_node | bool
6767
- oracle_pdbs is defined
6868
- opdb.0.state == 'present'
6969
- oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
@@ -99,11 +99,11 @@
9999
sid: "{{ _oracle_db_instance_name | default(omit) }}"
100100
state: "restarted"
101101
force_restart: false
102-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
103102
with_nested:
104103
- "{{ oracle_databases }}"
105104
- "" # dummy to force odb.0 instead of item.
106105
when:
106+
- _orasw_meta_primary_node | bool
107107
- odb.0.restart_spparameter_changed | default(true)
108108
- oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
109109
- restart_spparameter_changed

roles/oradb_manage_pdb/tasks/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
port: "{{ listener_port_template }}"
2626
state: "{{ odb[1].state | default(omit) }}"
2727
environment: "{{ _oracle_env }}"
28-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
2928
with_nested:
3029
- "{{ oracle_databases }}"
3130
- "{{ oracle_pdbs }}"
@@ -39,6 +38,7 @@
3938
db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
4039
loop_var: odb
4140
when:
41+
- _orasw_meta_primary_node | bool
4242
- oracle_databases is defined
4343
- odb[0].oracle_db_name
4444
- oracle_pdbs is defined

roles/oradb_manage_profiles/tasks/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@
3737
attributes: {{ odb.1.attributes }}
3838
db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
3939
when:
40+
- _orasw_meta_primary_node | bool
4041
- oracle_databases is defined
4142
- odb.0.state == 'present'
4243
- oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
4344
- odb.1 is defined
44-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
4545
become: true
4646
become_user: "{{ oracle_user }}"
4747
vars:
@@ -88,6 +88,7 @@
8888
attributes: {{ opdb.1.attributes }}
8989
cdb_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
9090
when:
91+
- _orasw_meta_primary_node | bool
9192
- oracle_pdbs is defined
9293
- opdb.0 is defined
9394
- opdb.0.state == 'present'
@@ -96,7 +97,6 @@
9697
- >-
9798
oracle_databases | selectattr('oracle_db_name', 'equalto', opdb.0.cdb)
9899
| map(attribute='state') | list | first == 'present'
99-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
100100
become: true
101101
become_user: "{{ oracle_user }}"
102102
vars:

roles/oradb_manage_redo/tasks/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
size: "{{ odb.redolog_size }}"
2424
groups: "{{ odb.redolog_groups }}"
2525
environment: "{{ _oracle_env }}"
26-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
2726
loop: "{{ oracle_databases }}"
2827
when:
28+
- _orasw_meta_primary_node | bool
2929
- oracle_databases is defined
3030
- odb.redolog_size is defined
3131
- odb.redolog_groups is defined

roles/oradb_manage_roles/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ Manage roles in Oracle
1919

2020
## Discovered Tags
2121

22-
**_users,grants_**
22+
**_grants_**
23+
24+
**_users_**
2325

2426

2527
## Dependencies

roles/oradb_manage_roles/tasks/main.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
skip_missing: true
1818
environment: "{{ _oracle_env }}"
1919
when:
20+
- _orasw_meta_primary_node | bool
2021
- oracle_databases is defined
2122
- odb.0.state == 'present'
2223
- oracledb_facts[_oracle_db_unique_name]['state'] | default('') == 'present'
@@ -30,10 +31,11 @@
3031
role {{ odb.1.name }}
3132
state {{ odb.1.state }}
3233
db_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
33-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
3434
become: true
3535
become_user: "{{ oracle_user }}"
36-
tags: users,grants
36+
tags:
37+
- users
38+
- grants
3739

3840
- name: Manage roles (pdb)
3941
opitzconsulting.ansible_oracle.oracle_role:
@@ -52,6 +54,7 @@
5254
skip_missing: true
5355
environment: "{{ _oracle_env_pdb }}"
5456
when:
57+
- _orasw_meta_primary_node | bool
5558
- oracle_pdbs is defined
5659
- opdb.0 is defined
5760
- opdb.0.state == 'present'
@@ -69,7 +72,8 @@
6972
role: {{ opdb.1.name }},
7073
state: {{ opdb.1.state }}
7174
cdb_state: {{ oracledb_facts[_oracle_db_unique_name]['state'] | default('') }}
72-
run_once: "{{ _oraswgi_meta_configure_cluster }}"
7375
become: true
7476
become_user: "{{ oracle_user }}"
75-
tags: users,grants
77+
tags:
78+
- users
79+
- grants

roles/oradb_manage_services/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,11 @@ Manage services in Oracle
2020

2121
## Discovered Tags
2222

23-
**_create_service,services_**
23+
**_create_service_**
2424

25-
**_start_service,services_**
25+
**_services_**
26+
27+
**_start_service_**
2628

2729
## Open Tasks
2830

0 commit comments

Comments
 (0)