ansible-lint: noqa for no-changed-when

Author: Rendanic

.ansible-lint

@@ -3,7 +3,6 @@ use_default_rules: true
 
 skip_list:
   - name[casing]
-  - no-changed-when
 
 exclude_paths:
   - .github

opitzconsulting-ansible_oracle-3.5.1.tar.gz

@@ -1,6 +1,7 @@
 ---
 - name: oradb_datapatch | Start listener
   ansible.builtin.shell: "export PATH=${ORACLE_HOME}/bin:${PATH}; lsnrctl start {{ lsnrinst.listener_name }} /dev/null; exit 0"
+  # noqa no-changed-when
   environment: "{{ oracle_env_lsnrctl }}"
   become_user: "{{ oracle_user }}"
   with_items: "{{ listener_installed }}"

roles/oradb_datapatch/tasks/main.yml

@@ -212,6 +212,7 @@
 - name: Wallet createCredential
   ansible.builtin.shell:
     cmd: 'echo "$stdin" | {{ oracle_home_db }}/bin/mkstore -wrl "{{ rman_wallet_loc }}" -nologo -createCredential "$rman_tnsalias" "$rman_user" "$rman_password"'
+  # noqa no-changed-when
   become: true
   become_user: "{{ oracle_user }}"
   environment:
@@ -259,7 +260,7 @@
 # The task is only execute once on master_node when GI is installed!
 # no catalog connection, because setting initial parameters with catalog takes much more time
 - name: Execute RMAN-Script at playbook
-  # noqa risky-shell-pipe
+  # noqa risky-shell-pipe no-changed-when
   ansible.builtin.shell: "{{ oracle_base }}/bin/rman_backup.sh -a {{ item.1.name }} -s {{ item.0.oracle_db_instance_name | default(item.0.oracle_db_name) }} -r {{ rman_script_dir }} -l {{ rman_log_dir }} | tee -a {{ rman_cron_logdir }}/rman_{{ item.1.name }}.log"
   environment:
     PATH: /bin:/usr/bin

roles/oradb_rman/tasks/main.yml

@@ -190,7 +190,7 @@
 
 - name: ssh-keys | Generate SSH keys
   local_action: shell rm -f /tmp/id_rsa*; ssh-keygen -q -N "" -f /tmp/id_rsa ; chmod +r /tmp/id_rsa; cat /tmp/id_rsa.pub > /tmp/authorized_keys  # noqa yaml deprecated-command-syntax deprecated-local-action ignore-errors
-    # noqa fqcn[action-core]
+    # noqa fqcn[action-core] no-changed-when
   ignore_errors: true
   run_once: "{{ configure_cluster }}"
   when: configure_ssh and configure_cluster and old_ssh_config
@@ -230,7 +230,7 @@
 
 - name: ssh-keys | Add short name to known_hosts
   local_action: shell ssh-keyscan -p {{ ansible_ssh_port | default(22) }} -H {{ ansible_hostname }} 2> /dev/null >> {{ keyfile }}  # noqa deprecated-local-action ignore-errors
-  # noqa fqcn[action-core]
+  # noqa fqcn[action-core] no-changed-when
   ignore_errors: true
   become: false
   when: configure_ssh and configure_cluster and old_ssh_config
@@ -239,7 +239,7 @@
 
 - name: ssh-keys | Add FQDN to known_hosts
   local_action: shell ssh-keyscan -p {{ ansible_ssh_port | default(22) }} -H {{ ansible_fqdn }} 2> /dev/null >> {{ keyfile }}  # noqa yaml ignore-errors deprecated-local-action
-  # noqa fqcn[action-core]
+  # noqa fqcn[action-core] no-changed-when
   ignore_errors: true
   become: false
   when: configure_ssh and configure_cluster and old_ssh_config
@@ -248,7 +248,7 @@
 
 - name: ssh-keys | Add IPv4 to known_hosts
   local_action: shell ssh-keyscan -p {{ ansible_ssh_port | default(22) }} -H {{ ansible_default_ipv4.address }} 2> /dev/null >> {{ keyfile }}  # noqa ignore-errors deprecated-local-action
-  # noqa fqcn[action-core]
+  # noqa fqcn[action-core] no-changed-when
   ignore_errors: true
   become: false
   when: configure_ssh and configure_cluster and old_ssh_config

roles/orahost/tasks/main.yml

@@ -13,7 +13,7 @@
 
     - name: ssh-keys | get public key for grid user
       ansible.builtin.shell: cat /home/{{ grid_user }}/.ssh/id_rsa.pub
-      # noqa command-instead-of-shell
+      # noqa command-instead-of-shell no-changed-when
       register: grid_key
       when: role_separation
       tags:

roles/orahost_ssh/tasks/main.yml

@@ -26,18 +26,19 @@
 
 - name: udev | Run script to create udev rules
   ansible.builtin.shell: "{{ oracle_rsp_stage }}/setup-udev-rules.sh"
-  # noqa command-instead-of-shell
+  # noqa command-instead-of-shell no-changed-when
   when: device_persistence == 'udev'
   tags: udev
 
 - name: udev | Reload rules
   ansible.builtin.shell: partprobe;sleep 5; udevadm control --reload-rules; udevadm trigger
+  # noqa no-changed-when
   when: device_persistence == 'udev'
   tags: udev
 
 - name: udev | List device aliases (register)
   ansible.builtin.shell: ls -l {{ oracle_asm_disk_string }}
-  # noqa command-instead-of-shell
+  # noqa command-instead-of-shell no-changed-when
   when: device_persistence == 'udev'
   tags: udev
   register: lsdevice

roles/orahost_storage/tasks/udev.yml

@@ -26,6 +26,7 @@
 
     - name: Create Golden-Image
       ansible.builtin.command: "{{ oracle_home_db }}/runInstaller -silent -createGoldImage -destinationLocation {{ golden_image_dest }}/{{ dbh.home }}"
+      # noqa no-changed-when
       with_items:
         - "{{ db_homes_installed | list | unique }}"
       loop_control:

roles/oraswdb_golden_image/tasks/main.yml

@@ -41,7 +41,7 @@
 
 - name: install_home_db | Install Oracle Database Server
   ansible.builtin.shell: "{{ oracle_stage_install }}/{{ db_homes_config[dbh.home]['version'] }}/database/runInstaller -responseFile {{ oracle_rsp_stage }}/{{ oracle_db_responsefile }} -ignorePrereq -ignoreSysPrereqs -silent -waitforcompletion"
-  # noqa yaml command-instead-of-shell
+  # noqa yaml command-instead-of-shell no-changed-when
   become: true
   become_user: "{{ oracle_user }}"
   run_once: "{{ configure_cluster }}"

roles/oraswdb_install/tasks/11.2.0.3.yml

@@ -39,7 +39,7 @@
 
 - name: install_home_db | Install Oracle Database Server
   ansible.builtin.shell: "{{ oracle_stage_install }}/{{ db_homes_config[dbh.home]['version'] }}/database/runInstaller -responseFile {{ oracle_rsp_stage }}/{{ oracle_db_responsefile }} -ignorePrereq -ignoreSysPrereqs -silent -waitforcompletion"
-  # noqa yaml command-instead-of-shell
+  # noqa yaml command-instead-of-shell no-changed-when
   become: true
   become_user: "{{ oracle_user }}"
   run_once: "{{ configure_cluster }}"