revert "crc32: use __BYTE_ORDER macro for endian detection"

akpm00 · torvalds · commit 0d2daf5cc858 · 2010-05-26T08:19:23.000-07:00
It doesn't work on big-endian - those architectures don't define
__LITTLE_ENDIAN.

Cc: Joakim Tjernlund &lt;joakim.tjernlund@transmode.se&gt;
Reported-by: Stephen Rothwell &lt;sfr@canb.auug.org.au&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/lib/crc32.c b/lib/crc32.c
@@ -50,7 +50,7 @@ MODULE_LICENSE("GPL");
 static inline u32
 crc32_body(u32 crc, unsigned char const *buf, size_t len, const u32 (*tab)[256])
 {
-# if __BYTE_ORDER == __LITTLE_ENDIAN
+# ifdef __LITTLE_ENDIAN
 #  define DO_CRC(x) crc = tab[0][(crc ^ (x)) & 255] ^ (crc >> 8)
 #  define DO_CRC4 crc = tab[3][(crc) & 255] ^ \
 		tab[2][(crc >> 8) & 255] ^ \

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ MODULE_LICENSE("GPL");`
`50`	`50`	`static inline u32`
`51`	`51`	`crc32_body(u32 crc, unsigned char const buf, size_t len, const u32 (tab)[256])`
`52`	`52`	`{`
`53`		`-# if __BYTE_ORDER == __LITTLE_ENDIAN`
	`53`	`+# ifdef __LITTLE_ENDIAN`
`54`	`54`	`# define DO_CRC(x) crc = tab[0][(crc ^ (x)) & 255] ^ (crc >> 8)`
`55`	`55`	`# define DO_CRC4 crc = tab[3][(crc) & 255] ^ \`
`56`	`56`	`tab[2][(crc >> 8) & 255] ^ \`