From ede628650fcbe29af505f14e096bf632948d2aa1 Mon Sep 17 00:00:00 2001 From: Amarthya Valija Date: Wed, 8 Oct 2025 13:59:01 -0400 Subject: [PATCH] Revert "Fix endpoint admission test namespace creation for ROSA Avoid attempting to create existing namespaces like kube-system which triggers managed-cluster-validating-webhooks in ROSA." This reverts commit 46bbe12a32ecae26b339e9168e0cdcf1a426ff25. --- test/extended/networking/endpoint_admission.go | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/test/extended/networking/endpoint_admission.go b/test/extended/networking/endpoint_admission.go index 650bca400c05..9f5e8228a274 100644 --- a/test/extended/networking/endpoint_admission.go +++ b/test/extended/networking/endpoint_admission.go @@ -186,15 +186,9 @@ func testOneEndpointSlice(oc *exutil.CLI, client kubernetes.Interface, addrType, } func getClientForServiceAccount(adminClient kubernetes.Interface, clientConfig *rest.Config, namespace, name string) (*kubernetes.Clientset, *rest.Config, error) { - _, err := adminClient.CoreV1().Namespaces().Get(context.Background(), namespace, metav1.GetOptions{}) - if err != nil { - if !errors.IsNotFound(err) { - return nil, nil, err - } - _, err = adminClient.CoreV1().Namespaces().Create(context.Background(), &corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: namespace}}, metav1.CreateOptions{}) - if err != nil { - return nil, nil, err - } + _, err := adminClient.CoreV1().Namespaces().Create(context.Background(), &corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: namespace}}, metav1.CreateOptions{}) + if err != nil && !errors.IsAlreadyExists(err) { + return nil, nil, err } _, err = adminClient.CoreV1().ServiceAccounts(namespace).Create(context.Background(), &corev1.ServiceAccount{ObjectMeta: metav1.ObjectMeta{Name: name}}, metav1.CreateOptions{})