Use latest json-smart lib #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
skip-changelog
Maintenance
martin-gaievski
force-pushed
the
fixed_cve_for_jayway_json_lib
branch
from
c14ee89 to
55d2acc
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
fixed_cve_for_jayway_json_lib
branch
from
55d2acc to
cb6f59a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1223 +/- ##
============================================
- Coverage 81.80% 81.79% -0.02%
+ Complexity 2606 1303 -1303
============================================
Files 190 95 -95
Lines 8922 4461 -4461
Branches 1520 760 -760
============================================
- Hits 7299 3649 -3650
+ Misses 1032 517 -515
+ Partials 591 295 -296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
requested review from
VijayanB,
heemin32,
jmazanec15,
junqiu-lei,
minalsha,
model-collapse,
naveentatikonda,
navneet1v,
sean-zheng-amazon,
vamshin,
vibrantvarun,
yuye-aws,
zane-neo and
zhichao-aws
as code owners
martin-gaievski
changed the title
heemin32
approved these changes
Mar 11, 2025
junqiu-lei
approved these changes
Mar 11, 2025
ryanbogan
pushed a commit
to ryanbogan/neural-search
that referenced
this pull request
Apr 10, 2025
* Switch from json-path 2.9.0 to latest json-smart Signed-off-by: Martin Gaievski <[email protected]>
heemin32
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Switch from json-path 2.9.0 to latest json-smart Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 57124dd)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Switch from json-path 2.9.0 to latest json-smart Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 57124dd)
This was referenced Jul 18, 2025
heemin32
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Switch from json-path 2.9.0 to latest json-smart (cherry picked from commit 57124dd) Signed-off-by: Martin Gaievski <[email protected]> Co-authored-by: Martin Gaievski <[email protected]>
heemin32
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Switch from json-path 2.9.0 to latest json-smart (cherry picked from commit 57124dd) Signed-off-by: Martin Gaievski <[email protected]> Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
json-path 2.9.0 has been flagged in CVE-2024-57699. They do not have fix yet, and their devs suggest to switch to json-smart json-path/JsonPath#1031.
We need to have this library for ml-commons, follow their strategy: keep json-path, but excluding json-smart part of it, and include json-mart of the proper version separately.
Picking up version of json-smart from the OS core, they added in the recent PR opensearch-project/OpenSearch#17569
Related Issues
#1222
Check List
[ ] New functionality includes testing.[ ] New functionality has been documented.[ ] API changes companion pull request created.--signoff.[ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.