generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 186
Use _list/indices API instead of _cat/index API in CatIndexTool #3243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zane-neo
merged 21 commits into
opensearch-project:main
from
zane-neo:migrate-cat-index-tool
Mar 12, 2025
+703
−375
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
05e02d2
Use _list/indices API instead of _cat/index API in CatIndexTool
zane-neo a8623cc
change assert to avoid flaky in test
zane-neo db1f517
add example of responsestr and change default size to 100
zane-neo ed4bb46
add ListIndexTool and revert CatIndexTool change
zane-neo aa530b3
Use random string instead of number sequence
zane-neo 3a244a3
fix failure IT
zane-neo f455a1e
change comment to _list/indices API rest action file
zane-neo 7e915fb
add page size parameter from input and change sef4j to log4j
zane-neo e9f97af
format code
zane-neo b843479
Add UT for ListIndexTool
zane-neo baac942
rebase main
zane-neo 3a0f699
Fix UT failure
zane-neo 2a9030e
Change resource name to fix IT failure
zane-neo 498021a
Add more UTs to increase coverage
zane-neo c3acd85
Remove CatIndexTool to keep only ListIndexTool
zane-neo 41b70ad
Remove temp file
zane-neo a678c8f
Remove CatIndexTool
zane-neo 6e36cfc
Fix jacoco result not updated to latest commit issue
zane-neo 7f4b4d4
Change file path to under plugin module
zane-neo 58a5137
fix failure tests
zane-neo 1b5d510
Remove assert to ensure IT pass
zane-neo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
319 changes: 219 additions & 100 deletions
319
...nsearch/ml/engine/tools/CatIndexTool.java → ...search/ml/engine/tools/ListIndexTool.java
Large diffs are not rendered by default.
Oops, something went wrong.
248 changes: 0 additions & 248 deletions
248
ml-algorithms/src/test/java/org/opensearch/ml/engine/tools/CatIndexToolTests.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we add this?
This is failing all the time: https://github.com/opensearch-project/ml-commons/actions/runs/13911015452/job/38928296296
Please take a look @zane-neo