Skip to content

Conversation

@karenyrx
Copy link
Contributor

Description

Stacked on top of #19447
Implement GRPC Ids, Range, and Terms Set queries

Related Issues

Resolves #18907

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Sep 29, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 8dbf346: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen X <[email protected]>
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from 8dbf346 to b7abcfb Compare September 29, 2025 07:27
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from b7abcfb to d89048d Compare September 29, 2025 07:30
@github-actions
Copy link
Contributor

✅ Gradle check result for d89048d: SUCCESS

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 95.26316% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.96%. Comparing base (259add3) to head (47d4726).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...uest/search/query/RangeQueryBuilderProtoUtils.java 93.84% 1 Missing and 7 partials ⚠️
...t/search/query/TermsSetQueryBuilderProtoUtils.java 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19448      +/-   ##
============================================
+ Coverage     72.88%   72.96%   +0.07%     
- Complexity    70219    70342     +123     
============================================
  Files          5702     5708       +6     
  Lines        322202   322392     +190     
  Branches      46625    46686      +61     
============================================
+ Hits         234832   235226     +394     
+ Misses        68418    68217     -201     
+ Partials      18952    18949       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

✅ Gradle check result for d0cbe21: SUCCESS

@github-actions
Copy link
Contributor

✅ Gradle check result for a44d86c: SUCCESS

@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from a44d86c to 08037b3 Compare September 30, 2025 00:48
@karenyrx karenyrx marked this pull request as ready for review September 30, 2025 00:50
@karenyrx karenyrx requested a review from a team as a code owner September 30, 2025 00:50
@github-actions
Copy link
Contributor

❌ Gradle check result for 70eb7b3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 24c230d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for aef0221: SUCCESS

@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from f9228ff to 1fb2f8d Compare September 30, 2025 18:22
@github-actions
Copy link
Contributor

❌ Gradle check result for 1fb2f8d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 98cafd2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 47d4726: SUCCESS

@mch2 mch2 merged commit 723f6d5 into opensearch-project:main Sep 30, 2025
33 checks passed
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…ueries (opensearch-project#19448)

* upgrade to protobufs 0.18.0

Signed-off-by: Karen X <[email protected]>

* add tests

Signed-off-by: Karen X <[email protected]>

* [GRPC][Term-level queries] Implement Ids, Range, Termsset

Signed-off-by: Karen X <[email protected]>

* package private

Signed-off-by: Karen X <[email protected]>

* remove unused variables

Signed-off-by: Karen X <[email protected]>

* spotless

Signed-off-by: Karen X <[email protected]>

* remove duplicate from merge conflict

Signed-off-by: Karen X <[email protected]>

* spotless and fix merge conflict

Signed-off-by: Karen X <[email protected]>

* spotless

Signed-off-by: Karen X <[email protected]>

* fix merge conflict and spotless

Signed-off-by: Karen X <[email protected]>

---------

Signed-off-by: Karen X <[email protected]>
Co-authored-by: karenx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] [GRPC][Search] Implement Term-level Query Proto Converters

2 participants