S3 crt support #18739
Closed
S3 crt support #18739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Signed-off-by: Pranit Kumar <[email protected]>
Signed-off-by: Pranit Kumar <[email protected]>
Signed-off-by: Pranit Kumar <[email protected]>
Signed-off-by: Pranit Kumar <[email protected]>
Contributor
|
❌ Gradle check result for 5d6e587: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Pranit Kumar <[email protected]>
Contributor
|
❌ Gradle check result for 653c4ec: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Pranit Kumar <[email protected]>
Contributor
|
❌ Gradle check result for 38a28f5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Pranit Kumar <[email protected]>
Contributor
|
❌ Gradle check result for d20abab: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Pranit Kumar <[email protected]>
Contributor
|
❌ Gradle check result for 4a9caa7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…-project#18715) * Fix max_score is null when sorting on score firstly Signed-off-by: Binlong Gao <[email protected]> * modify changelog Signed-off-by: Binlong Gao <[email protected]> * Fix test failure Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
…ct#18610) * Changes for the Upload Workflow for merged segments Signed-off-by: Aditi Goyal <[email protected]> * Addressed Todos Signed-off-by: Aditi Goyal <[email protected]> * Added Test Cases Signed-off-by: Aditi Goyal <[email protected]> * Removed the usage of Forbidden APIs Signed-off-by: Aditi Goyal <[email protected]> * Updated the code to include priority upload as paramter Signed-off-by: Aditi Goyal <[email protected]> * Updated the remote listener to use remote upploader interface Signed-off-by: Aditi Goyal <[email protected]> * Added JavaDocs across the changes Signed-off-by: Aditi Goyal <[email protected]> * Addressed spotless check Signed-off-by: Aditi Goyal <[email protected]> * Dummy commit(can be reverted) Signed-off-by: Aditi Goyal <[email protected]> * Revert "Dummy commit(can be reverted)" This reverts commit e542b99. Signed-off-by: Aditi Goyal <[email protected]> --------- Signed-off-by: Aditi Goyal <[email protected]> Co-authored-by: Aditi Goyal <[email protected]>
…8737) Signed-off-by: guojialiang <[email protected]>
* Code Improvement Signed-off-by: Prudhvi Godithi <[email protected]> * Code Improvement with a new method Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>
…ns/repository-hdfs (opensearch-project#18745) * Bump org.apache.commons:commons-lang3 in /plugins/repository-hdfs Bumps org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-version: 3.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ildSrc/src/testKit/thirdPartyAudit/sample_jars (opensearch-project#18744) * Bump org.apache.logging.log4j:log4j-core Bumps org.apache.logging.log4j:log4j-core from 2.25.0 to 2.25.1. --- updated-dependencies: - dependency-name: org.apache.logging.log4j:log4j-core dependency-version: 2.25.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ns/repository-azure (opensearch-project#18742) * Bump com.azure:azure-storage-common in /plugins/repository-azure Bumps [com.azure:azure-storage-common](https://github.com/Azure/azure-sdk-for-java) from 12.29.0 to 12.29.1. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-storage-blob_12.29.0...azure-storage-blob_12.29.1) --- updated-dependencies: - dependency-name: com.azure:azure-storage-common dependency-version: 12.29.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <[email protected]>
…s/plugin-cli (opensearch-project#18743) * Bump com.google.jimfs:jimfs in /distribution/tools/plugin-cli Bumps [com.google.jimfs:jimfs](https://github.com/google/jimfs) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/google/jimfs/releases) - [Commits](google/jimfs@v1.3.0...v1.3.1) --- updated-dependencies: - dependency-name: com.google.jimfs:jimfs dependency-version: 1.3.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <[email protected]>
…ensearch-project#18660) Signed-off-by: Shreyansh Ray <[email protected]>
…earch-project#18494) The `upgrade-cli` tool is deprecated and no longer needed. - Removed: distribution/tools/upgrade-cli - Cleaned up: settings.gradle, distribution/build.gradle - Deleted: distribution/src/bin/opensearch-upgrade(.bat) Signed-off-by: BeomSeogKim <[email protected]>
* port over plugin extension, double check with knn tests Signed-off-by: TJ Neuenfeldt <[email protected]> * changelog, added tests, changed to contexualpb for context Signed-off-by: TJ Neuenfeldt <[email protected]> * spotless Signed-off-by: TJ Neuenfeldt <[email protected]> * renamed, made extension point a function Signed-off-by: TJ Neuenfeldt <[email protected]> * changelog, default ctors Signed-off-by: TJ Neuenfeldt <[email protected]> * added getter, changed to findProfileBreakdown Signed-off-by: TJ Neuenfeldt <[email protected]> * changelog and abstractpb Signed-off-by: TJ Neuenfeldt <[email protected]> * trigger Signed-off-by: TJ Neuenfeldt <[email protected]> * revert breaking change Signed-off-by: TJ Neuenfeldt <[email protected]> * trigger Signed-off-by: TJ Neuenfeldt <[email protected]> * trigger build Signed-off-by: TJ Neuenfeldt <[email protected]> * search module nit fix Signed-off-by: TJ Neuenfeldt <[email protected]> * spotless Signed-off-by: TJ Neuenfeldt <[email protected]> --------- Signed-off-by: TJ Neuenfeldt <[email protected]> Signed-off-by: TJ Neuenfeldt <[email protected]>
Signed-off-by: Pranit Kumar <[email protected]>
pranikum
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
peternied,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Signed-off-by: Pranit Kumar <[email protected]>
Contributor
Author
|
Closing the PR . Will ope n a clean one |
Contributor
|
❌ Gradle check result for 0b28b75: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of this PR we are adding support for S3 CRT client for S3 async client. Currently the default Http client used was NettyAsyncHttpClient. However as per our perf testing we have seen an improvement of approximately 5-7% when using CRT client.
Related Issues
Resolves #18535 #18535
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.