Skip to content

Conversation

@andrross
Copy link
Member

@andrross andrross commented Jun 25, 2025

Commit d404f33 has incorrect version guards which are manifesting as flaky failures in MixedClusterClientYamlTestSuiteIT.

See #18480 (comment) for more details

Related Issues

Resolves #14294

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Commit `d404f332` has incorrect version guards which are manifesting as
flaky failures in MixedClusterClientYamlTestSuiteIT.

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross requested a review from a team as a code owner June 25, 2025 17:44
@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. autocut flaky-test Random test failure that succeeds on second run Indexing Indexing, Bulk Indexing and anything related to indexing labels Jun 25, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for e9f5bff:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for e9f5bff: SUCCESS

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.67%. Comparing base (87022b7) to head (e9f5bff).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../main/java/org/opensearch/cluster/ClusterInfo.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #18614   +/-   ##
=========================================
  Coverage     72.66%   72.67%           
- Complexity    68231    68255   +24     
=========================================
  Files          5555     5556    +1     
  Lines        313857   313887   +30     
  Branches      45522    45527    +5     
=========================================
+ Hits         228073   228118   +45     
- Misses        67207    67249   +42     
+ Partials      18577    18520   -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks merged commit bfbd3c4 into opensearch-project:main Jun 25, 2025
36 of 40 checks passed
@sunqijun1
Copy link
Contributor

@andrross I found that this problem has occurred again. I guess it wasn't completely fixed.

@andrross
Copy link
Member Author

andrross commented Aug 4, 2025

@andrross I found that this problem has occurred again. I guess it wasn't completely fixed.

@sunqijun1 Can you provide more details? Every serialization change must be properly versioned with these manual checks so it is possible for these types of issues to continue to happen.

@andrross andrross deleted the fix-serde-failure branch August 4, 2025 16:08
@sunqijun1
Copy link
Contributor

@andrross I found that this problem has occurred again. I guess it wasn't completely fixed.

@sunqijun1 Can you provide more details? Every serialization change must be properly versioned with these manual checks so it is possible for these types of issues to continue to happen.

such like https://build.ci.opensearch.org/job/gradle-check/61443/https://build.ci.opensearch.org/job/gradle-check/61592/,https://github.com/opensearch-project/OpenSearch/pull/18901

tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
)

Commit `d404f332` has incorrect version guards which are manifesting as
flaky failures in MixedClusterClientYamlTestSuiteIT.

Signed-off-by: Andrew Ross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autocut flaky-test Random test failure that succeeds on second run Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog >test-failure Test failure from CI, local build, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT

3 participants