-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix serialization failure due to wrong version #18614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Commit `d404f332` has incorrect version guards which are manifesting as flaky failures in MixedClusterClientYamlTestSuiteIT. Signed-off-by: Andrew Ross <[email protected]>
|
❌ Gradle check result for e9f5bff: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18614 +/- ##
=========================================
Coverage 72.66% 72.67%
- Complexity 68231 68255 +24
=========================================
Files 5555 5556 +1
Lines 313857 313887 +30
Branches 45522 45527 +5
=========================================
+ Hits 228073 228118 +45
- Misses 67207 67249 +42
+ Partials 18577 18520 -57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@andrross I found that this problem has occurred again. I guess it wasn't completely fixed. |
@sunqijun1 Can you provide more details? Every serialization change must be properly versioned with these manual checks so it is possible for these types of issues to continue to happen. |
such like https://build.ci.opensearch.org/job/gradle-check/61443/ ,https://build.ci.opensearch.org/job/gradle-check/61592/,https://github.com/opensearch-project/OpenSearch/pull/18901 |
) Commit `d404f332` has incorrect version guards which are manifesting as flaky failures in MixedClusterClientYamlTestSuiteIT. Signed-off-by: Andrew Ross <[email protected]>
Commit d404f33 has incorrect version guards which are manifesting as flaky failures in MixedClusterClientYamlTestSuiteIT.
See #18480 (comment) for more details
Related Issues
Resolves #14294
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.