Use single quotes in reproduction command #18533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterized tests will output test names that include double quotes in
the test case, such as:
```
./gradlew ':server:internalClusterTest' --tests "org.opensearch.recovery.RecoveryWhileUnderLoadIT" -Dtests.method="testRecoverWhileUnderLoadWithDerivedSource {p0={"cluster.indices.replication.strategy":"SEGMENT"}}"
```
The nested double quotes do not work appropriately when trying to run
the command. This avoids that problem by using single quotes.
Signed-off-by: Andrew Ross <[email protected]>
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18533 +/- ##
============================================
+ Coverage 72.71% 72.76% +0.04%
- Complexity 68138 68166 +28
============================================
Files 5540 5540
Lines 313384 313384
Branches 45473 45473
============================================
+ Hits 227892 228048 +156
+ Misses 66924 66813 -111
+ Partials 18568 18523 -45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwperks
approved these changes
Jun 17, 2025
prudhvigodithi
approved these changes
Jun 17, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
Parameterized tests will output test names that include double quotes in
the test case, such as:
```
./gradlew ':server:internalClusterTest' --tests "org.opensearch.recovery.RecoveryWhileUnderLoadIT" -Dtests.method="testRecoverWhileUnderLoadWithDerivedSource {p0={"cluster.indices.replication.strategy":"SEGMENT"}}"
```
The nested double quotes do not work appropriately when trying to run
the command. This avoids that problem by using single quotes.
Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 225b0f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Jun 18, 2025
Parameterized tests will output test names that include double quotes in
the test case, such as:
```
./gradlew ':server:internalClusterTest' --tests "org.opensearch.recovery.RecoveryWhileUnderLoadIT" -Dtests.method="testRecoverWhileUnderLoadWithDerivedSource {p0={"cluster.indices.replication.strategy":"SEGMENT"}}"
```
The nested double quotes do not work appropriately when trying to run
the command. This avoids that problem by using single quotes.
(cherry picked from commit 225b0f8)
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Parameterized tests will output test names that include double quotes in
the test case, such as:
```
./gradlew ':server:internalClusterTest' --tests "org.opensearch.recovery.RecoveryWhileUnderLoadIT" -Dtests.method="testRecoverWhileUnderLoadWithDerivedSource {p0={"cluster.indices.replication.strategy":"SEGMENT"}}"
```
The nested double quotes do not work appropriately when trying to run
the command. This avoids that problem by using single quotes.
Signed-off-by: Andrew Ross <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Parameterized tests will output test names that include double quotes in
the test case, such as:
```
./gradlew ':server:internalClusterTest' --tests "org.opensearch.recovery.RecoveryWhileUnderLoadIT" -Dtests.method="testRecoverWhileUnderLoadWithDerivedSource {p0={"cluster.indices.replication.strategy":"SEGMENT"}}"
```
The nested double quotes do not work appropriately when trying to run
the command. This avoids that problem by using single quotes.
Signed-off-by: Andrew Ross <[email protected]>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
Parameterized tests will output test names that include double quotes in
the test case, such as:
```
./gradlew ':server:internalClusterTest' --tests "org.opensearch.recovery.RecoveryWhileUnderLoadIT" -Dtests.method="testRecoverWhileUnderLoadWithDerivedSource {p0={"cluster.indices.replication.strategy":"SEGMENT"}}"
```
The nested double quotes do not work appropriately when trying to run
the command. This avoids that problem by using single quotes.
Signed-off-by: Andrew Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterized tests will output test names that include double quotes in the test case, such as:
The nested double quotes do not work appropriately when trying to run the command. This avoids that problem by using single quotes.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.