Skip to content

Conversation

@reta
Copy link
Contributor

@reta reta commented Jun 11, 2025

Description

Activate Detect Breaking Changes Github Action since we have 3.0.0 baseline

Related Issues

Closes #18202

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from jed326 as a code owner June 11, 2025 23:53
@reta reta requested review from a team and peternied as code owners June 11, 2025 23:53
@reta
Copy link
Contributor Author

reta commented Jun 12, 2025

@andrross @msfroh @cwperks tons of breaking changes already ....

@github-actions
Copy link
Contributor

❌ Gradle check result for d340204: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the activate.detect.breaking.changes branch from d340204 to 6099c70 Compare June 16, 2025 11:58
@github-actions
Copy link
Contributor

❌ Gradle check result for 6099c70: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

Related issue: #18202

@reta reta added v3.2.0 and removed backport 3.1 labels Jun 16, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 6099c70: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request labels Jun 16, 2025
@github-actions
Copy link
Contributor

✅ Gradle check result for 6099c70: SUCCESS

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.64%. Comparing base (3078649) to head (6099c70).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
.../org/opensearch/search/internal/SearchContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #18501   +/-   ##
=========================================
  Coverage     72.64%   72.64%           
+ Complexity    68070    68038   -32     
=========================================
  Files          5537     5537           
  Lines        313404   313382   -22     
  Branches      45476    45472    -4     
=========================================
- Hits         227658   227647   -11     
+ Misses        67241    67233    -8     
+ Partials      18505    18502    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit fe3f454 into opensearch-project:main Jun 17, 2025
42 of 47 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 17, 2025
…seline (#18501)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit fe3f454)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@skumawat2025
Copy link
Contributor

Hi @reta Any thoughts on how can i resolve the breaking changes in this PR: #18467.

It is failing with

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':server:japicmp'.
> A failure occurred while executing me.champeau.gradle.japicmp.JApiCmpWorkAction
   > Detected binary changes.
         - current: opensearch-3.1.0-SNAPSHOT.jar
         - baseline: opensearch-3.0.0.jar.

andrross pushed a commit that referenced this pull request Jun 17, 2025
…seline (#18501) (#18538)

(cherry picked from commit fe3f454)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.1 Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request skip-changelog v3.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Enable breaking changes check on main after 3.0 release

3 participants