Skip to content

Conversation

@skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented Jun 9, 2025

Description

This PR:

  • Implements local file scanning to warm up fileCache during node startup, reducing remote store downloads
  • Logic to cleans up index and shard paths during warm index deletion. Reference PR.
  • Fixes flaky tests in WarmIndexSegmentReplicationIT

Related Issues

Resolves #17526, #18157

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working disabled-test Issues that are used by an AwaitsFix annotation to temporarily disable a broken test Storage:Remote labels Jun 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

❌ Gradle check result for 8c2bb1b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for ef7f263: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the filecache-bootup branch 2 times, most recently from e5c91f0 to 7d8da5c Compare June 17, 2025 14:57
@github-actions
Copy link
Contributor

❌ Gradle check result for 7d8da5c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Contributor

reta commented Jun 17, 2025

@skumawat2025 to answer your question, why the Detect Breaking Changes check fails:

You are modifying public method of the @PublicApi class by adding new argument - this will breaking each and every caller of this method if any.

How to fix it: bring the existing method back, mark it @Deprecated(forRemoval = true) and delegate to the new method:

    @Deprecated(forRemoval = true) 
    public static List<Path> collectFileCacheDataPath(NodePath fileCacheNodePath) throws IOException {
        return collectFileCacheDataPath(fileCacheNodePath, Settings.EMPTY);
    }

Sandeep Kumawat added 2 commits June 17, 2025 22:39
Signed-off-by: Sandeep Kumawat <[email protected]>
@skumawat2025
Copy link
Contributor Author

@skumawat2025 to answer your question, why the Detect Breaking Changes check fails:

You are modifying public method of the @PublicApi class by adding new argument - this will breaking each and every caller of this method if any.

How to fix it: bring the existing method back, mark it @Deprecated(forRemoval = true) and delegate to the new method:

    @Deprecated(forRemoval = true) 
    public static List<Path> collectFileCacheDataPath(NodePath fileCacheNodePath) throws IOException {
        return collectFileCacheDataPath(fileCacheNodePath, Settings.EMPTY);
    }

Thanks @reta this fixed the issue.

@github-actions
Copy link
Contributor

✅ Gradle check result for b92b514: SUCCESS

Signed-off-by: Sandeep Kumawat <[email protected]>
@github-actions
Copy link
Contributor

❕ Gradle check result for f6edc15: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@skumawat2025
Copy link
Contributor Author

Have run the WarmIndexSegmentReplicationIT 600+ times successfully and still running. Will keep monitoring for any flakiness.

BUILD SUCCESSFUL in 1m 31s
66 actionable tasks: 1 executed, 65 up-to-date
[2025-06-17 19:11:14] : ===================================================================
[2025-06-17 19:11:14] : counter=605
[2025-06-17 19:11:14] : ===================================================================
> Task :buildSrc:reaper:compileJava UP-TO-DATE

@gbbafna gbbafna merged commit 33d8fce into opensearch-project:main Jun 18, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Jun 18, 2025
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working disabled-test Issues that are used by an AwaitsFix annotation to temporarily disable a broken test skip-changelog Storage:Remote

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

FileCache bootup logic for Composite Directory

4 participants