-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Initialize FileCache for warm index on node boot-up/restart #18467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize FileCache for warm index on node boot-up/restart #18467
Conversation
|
❌ Gradle check result for 8c2bb1b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/store/CompositeDirectory.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/remote/filecache/CachedFullFileIndexInput.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/CompositeDirectory.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/remote/utils/cache/LRUCache.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/opensearch/test/InternalTestCluster.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/cache/RemovalReason.java
Outdated
Show resolved
Hide resolved
...ternalClusterTest/java/org/opensearch/indices/replication/WarmIndexSegmentReplicationIT.java
Show resolved
Hide resolved
8c2bb1b to
47a2b93
Compare
5423294 to
ef7f263
Compare
|
❌ Gradle check result for ef7f263: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e5c91f0 to
7d8da5c
Compare
|
❌ Gradle check result for 7d8da5c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
7d8da5c to
e5366c2
Compare
|
@skumawat2025 to answer your question, why the Detect Breaking Changes check fails: You are modifying public method of the How to fix it: bring the existing method back, mark it |
Signed-off-by: Sandeep Kumawat <[email protected]>
Signed-off-by: Sandeep Kumawat <[email protected]>
e5366c2 to
326bfe7
Compare
Thanks @reta this fixed the issue. |
b92b514 to
7436ba9
Compare
Signed-off-by: Sandeep Kumawat <[email protected]>
7436ba9 to
f6edc15
Compare
|
❕ Gradle check result for f6edc15: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
Have run the WarmIndexSegmentReplicationIT 600+ times successfully and still running. Will keep monitoring for any flakiness. |
…ch-project#18467) Signed-off-by: Sandeep Kumawat <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
…ch-project#18467) Signed-off-by: Sandeep Kumawat <[email protected]>
…ch-project#18467) Signed-off-by: Sandeep Kumawat <[email protected]>
Description
This PR:
Related Issues
Resolves #17526, #18157
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.