-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Increase default percentiles agg compression to 200 #18459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Increase default percentiles agg compression to 200 #18459
Conversation
Signed-off-by: Peter Alfonsi <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>
|
❌ Gradle check result for fb5a5f6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18459 +/- ##
============================================
+ Coverage 72.66% 72.69% +0.02%
- Complexity 67858 67877 +19
============================================
Files 5521 5521
Lines 312541 312541
Branches 45364 45364
============================================
+ Hits 227113 227195 +82
+ Misses 66903 66787 -116
- Partials 18525 18559 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Closing this for now, we are seeing some bugs within the library's MergingDigest implementation, so we're reverting the original change. (#18497) May revisit this if we are able to get confidence on MergingDigest, or if we can switch to the Apache implementation. |
Signed-off-by: Peter Alfonsi <[email protected]>
|
❌ Gradle check result for c4baaca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
jainankitk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the discussion #18458 (comment), I am not really sure if we need the change in default value yet.
Description
Changes default percentiles aggregation compression from 100 to 200, increasing accuracy.
Related Issues
#18458
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.