Skip to content

Conversation

@peteralfonsi
Copy link
Contributor

Description

Changes default percentiles aggregation compression from 100 to 200, increasing accuracy.

Related Issues

#18458

Check List

  • Functionality includes testing.
  • [N/A] API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Alfonsi <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

❌ Gradle check result for fb5a5f6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Peter Alfonsi <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

✅ Gradle check result for 6b665c0: SUCCESS

@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.69%. Comparing base (6ad6f4e) to head (6b665c0).
⚠️ Report is 493 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18459      +/-   ##
============================================
+ Coverage     72.66%   72.69%   +0.02%     
- Complexity    67858    67877      +19     
============================================
  Files          5521     5521              
  Lines        312541   312541              
  Branches      45364    45364              
============================================
+ Hits         227113   227195      +82     
+ Misses        66903    66787     -116     
- Partials      18525    18559      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peteralfonsi
Copy link
Contributor Author

Closing this for now, we are seeing some bugs within the library's MergingDigest implementation, so we're reverting the original change. (#18497) May revisit this if we are able to get confidence on MergingDigest, or if we can switch to the Apache implementation.

@github-actions
Copy link
Contributor

❌ Gradle check result for c4baaca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the discussion #18458 (comment), I am not really sure if we need the change in default value yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants