Performance tests #17834
Draft
Performance tests #17834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranu2502
force-pushed
the
performance-tests
branch
from
144e7d9 to
1ecaa7a
Compare
Contributor
Author
|
{"run-benchmark-test": "id_4"} |
Contributor
|
❌ Gradle check result for 1ecaa7a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2799/ . Final results will be published once the job is completed. |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/2799/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/56/
|
Contributor
Author
|
{"run-benchmark-test": "id_4"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2800/ . Final results will be published once the job is completed. |
Contributor
|
❌ Gradle check result for 8492836: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
there was an issue due to jenkins restart. submitting again. |
Contributor
|
{"run-benchmark-test": "id_4"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2810/ . Final results will be published once the job is completed. |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/2810/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/58/
|
Contributor
Author
Summary of the above benchmarksThe first benchmark was run with Java agent enabled and the second benchmark introduced a cache when trying to check wether a Protection Domain has a give permission. The performance of java-agent and stack walking in both the cases is primarily measured through the file interceptor, which is called for every Indexing and search operation. |
…SystemProvider.class Signed-off-by: Pranav Reddy <[email protected]>
… being thrown Signed-off-by: Pranav Reddy <[email protected]>
Signed-off-by: Pranav Reddy <[email protected]>
…File Interceptor Signed-off-by: Pranav Reddy <[email protected]>
Signed-off-by: Pranav Reddy <[email protected]>
Signed-off-by: Pranav Reddy <[email protected]>
Signed-off-by: Pranav Reddy <[email protected]>
…ing, must be low overhead) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>
pranu2502
force-pushed
the
performance-tests
branch
from
8492836 to
022643f
Compare
Contributor
Author
|
{"run-benchmark-test": "id_4"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/3003/ . Final results will be published once the job is completed. |
Contributor
|
❌ Gradle check result for a4abd07: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/3003/
|
Contributor
|
looks like we didn't had the baseline comparisons results published? |
Contributor
Author
|
Yes, I am not sure why though, but the baseline results will most probably show a regression because, the current changes includes interception of |
Contributor
Author
|
Nevertheless, I will run the benchmark again |
Contributor
Author
|
{"run-benchmark-test": "id_4"} |
Contributor
Author
|
@rishabh6788, is there any specific reason, we are not seeing the comparison with baseline here. cc: @kumargu |
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a Draft PR for performance benchmarks on Java-agent enabled
Related Issues
Resolves #17665
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.