Skip to content

[DRAFT] add validate before start timer #17815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[DRAFT] add validate before start timer #17815

wants to merge 10 commits into from

Conversation

@guojialiang92
Copy link
Contributor

@guojialiang92 guojialiang92 commented Apr 7, 2025 •
edited
Loading

Description

Related Issues

Check List

  • [] Functionality includes testing.
  • [] API changes companion pull request created, if applicable.
  • [] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@guojialiang92
avoid sr lag metric skew
ba0344c 
Signed-off-by: guojialiang <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

✅ Gradle check result for ba0344c: SUCCESS

@codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (cd266f3) to head (ba0344c).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...org/opensearch/index/seqno/ReplicationTracker.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17815      +/-   ##
============================================
- Coverage     72.55%   72.39%   -0.16%     
+ Complexity    66502    66409      -93     
============================================
  Files          5399     5399              
  Lines        307755   307756       +1     
  Branches      44656    44657       +1     
============================================
- Hits         223295   222806     -489     
- Misses        66266    66739     +473     
- Partials      18194    18211      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guojialiang92
add test
ebc6038 
Signed-off-by: guojialiang <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for ebc6038: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for 07187cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dependabot bot and others added 3 commits April 8, 2025 14:01
@dependabot @guojialiang92
Bump com.google.api.grpc:proto-google-iam-v1 from 1.33.0 to 1.49.1 in…
0ce496c 
… /plugins/repository-gcs (opensearch-project#17811)

* Bump com.google.api.grpc:proto-google-iam-v1 in /plugins/repository-gcs

Bumps [com.google.api.grpc:proto-google-iam-v1](https://github.com/googleapis/sdk-platform-java) from 1.33.0 to 1.49.1.
- [Release notes](https://github.com/googleapis/sdk-platform-java/releases)
- [Changelog](https://github.com/googleapis/sdk-platform-java/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/sdk-platform-java/commits)

---
updated-dependencies:
- dependency-name: com.google.api.grpc:proto-google-iam-v1
  dependency-version: 1.49.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @guojialiang92
Bump tj-actions/changed-files from 46.0.3 to 46.0.4 (opensearch-proje…
40e316b 
…ct#17813)

* Bump tj-actions/changed-files from 46.0.3 to 46.0.4

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 46.0.3 to 46.0.4.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v46.0.3...v46.0.4)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-version: 46.0.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@reta @guojialiang92
Fix FileInterceptor to deduce the access level from the list of OpenO…
68eefa2 
…ption (opensearch-project#17816)

Signed-off-by: Andriy Redko <[email protected]>
kumargu and others added 5 commits April 8, 2025 14:01
@kumargu @andrross @guojialiang92
Add a policy parser for Java Agent (opensearch-project#17753)
5bcce9e 
* Add a policy parser for java agent

Signed-off-by: Gulshan <[email protected]>

* Url no depricated version of url resolution

Signed-off-by: Gulshan <[email protected]>

* Remove unused methods and switch to modern Java collections

Signed-off-by: Gulshan <[email protected]>

* Use record classes and other small refactorings

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: Gulshan <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
@dependabot @guojialiang92
Bump ch.qos.logback:logback-core from 1.5.17 to 1.5.18 in /test/fixtu…
d0b696a 
…res/hdfs-fixture (opensearch-project#17809)

* Bump ch.qos.logback:logback-core in /test/fixtures/hdfs-fixture

Bumps [ch.qos.logback:logback-core](https://github.com/qos-ch/logback) from 1.5.17 to 1.5.18.
- [Release notes](https://github.com/qos-ch/logback/releases)
- [Commits](qos-ch/logback@v_1.5.17...v_1.5.18)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-core
  dependency-version: 1.5.18
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @guojialiang92
Bump com.azure:azure-core from 1.54.1 to 1.55.3 in /plugins/repositor…
010995b 
…y-azure (opensearch-project#17810)

* Bump com.azure:azure-core in /plugins/repository-azure

Bumps [com.azure:azure-core](https://github.com/Azure/azure-sdk-for-java) from 1.54.1 to 1.55.3.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](Azure/azure-sdk-for-java@azure-core_1.54.1...azure-core_1.55.3)

---
updated-dependencies:
- dependency-name: com.azure:azure-core
  dependency-version: 1.55.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cwperks @guojialiang92
Remove dependency on :test:framework in :libs:opensearch-agent-sm:age…
98d0f2c 
…nt-policy (opensearch-project#17821)

* Remove dependency on :test:framework in :libs:opensearch-agent-sm:agent-policy

Signed-off-by: Craig Perkins <[email protected]>

* Use JUnit

Signed-off-by: Craig Perkins <[email protected]>

* Disable more tasks

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
@sandeshkr419 @guojialiang92
[Star Tree] [Search] Resolving Range aggregations with Star-tree (ope…
0b01ea1 
…nsearch-project#17273)

* range aggs changes

---------

Signed-off-by: Sandesh Kumar <[email protected]>
@guojialiang92 guojialiang92 force-pushed the dev/avoid_sr_lag_metric_skew branch from 07187cf to 0b01ea1 Compare April 8, 2025 06:02
@guojialiang92 guojialiang92 changed the title [segment replication] Avoid skewed segment replication lag metric [DRAFT] add validate before start timer Apr 8, 2025
@guojialiang92 guojialiang92 deleted the dev/avoid_sr_lag_metric_skew branch April 8, 2025 06:17
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for 0b01ea1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Apr 14, 2025
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr

@jainankitk jainankitk Awaiting requested review from jainankitk

@linuxpi linuxpi Awaiting requested review from linuxpi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guojialiang92 @reta @kumargu @cwperks @sandeshkr419