-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Pull-based ingestion] Support multi-threaded ingestion along with upserts and deletes #17771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based ingestion] Support multi-threaded ingestion along with upserts and deletes #17771
Conversation
299bd94 to
3782d1d
Compare
3782d1d to
5fccdaa
Compare
|
❌ Gradle check result for 5fccdaa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5fccdaa to
ddc978d
Compare
|
❌ Gradle check result for 95970b5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
fa0f6a1 to
69cc527
Compare
|
❌ Gradle check result for 69cc527: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
69cc527 to
6330594
Compare
|
❕ Gradle check result for 6330594: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17771 +/- ##
============================================
+ Coverage 72.39% 72.48% +0.09%
- Complexity 66066 66306 +240
============================================
Files 5358 5387 +29
Lines 306500 307248 +748
Branches 44409 44563 +154
============================================
+ Hits 221888 222708 +820
+ Misses 66474 66332 -142
- Partials 18138 18208 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
6330594 to
f726ea0
Compare
|
❌ Gradle check result for f726ea0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f726ea0 to
c23f437
Compare
|
❌ Gradle check result for c23f437: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bharadwaj <[email protected]>
c23f437 to
a68cdf7
Compare
|
❕ Gradle check result for a68cdf7: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
| } | ||
|
|
||
| encounteredError = false; | ||
| if (results.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder in the corner case that the last processed message in the last batch runs into err after line 215, and also there's no new message after this message, then will this logic result in rewinding to the previous batch start pointer?
because this condition results.isEmpty() becomes true, and in the next iteration, encounteredError becomes false, then it will assume the lastProcessedPointer did not run ito error?
Description
ingestion_source.num_processor_threads. If not set, a default value of 1 will be used.Note that this PR adds the framework for multi-threaded writes, but does not allow users to turn on the feature. We'll allow users to use this feature once the feature is complete and we can support atleast/exactly once processing guarantees.
Related Issues
Builds on top of #16929
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.