[segment replication] Increase the default segment counter step size when replica promoting #17568
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guojialiang92
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
jed326,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
_No response_
enhancement
Contributor
|
❌ Gradle check result for 36c979d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
guojialiang92
force-pushed
the
dev/add_segment_counter_increment_step_setting
branch
from
36c979d to
c3d39c5
Compare
Contributor
|
❌ Gradle check result for c3d39c5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Mar 14, 2025
…er_increment_step_setting # Conflicts: # CHANGELOG.md
Contributor
|
❌ Gradle check result for 7676087: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…er_increment_step_setting
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17568 +/- ##
============================================
- Coverage 72.43% 72.41% -0.03%
+ Complexity 66789 66764 -25
============================================
Files 5449 5449
Lines 309085 309085
Branches 44979 44979
============================================
- Hits 223899 223809 -90
- Misses 66906 66924 +18
- Partials 18280 18352 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mch2
reviewed
Apr 8, 2025
…er_increment_step_setting
Signed-off-by: guojialiang <[email protected]>
guojialiang92
changed the title
Contributor
|
❌ Gradle check result for 010aa1c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: guojialiang <[email protected]>
guojialiang92
force-pushed
the
dev/add_segment_counter_increment_step_setting
branch
from
010aa1c to
4e08ac8
Compare
Contributor
mch2
approved these changes
Apr 10, 2025
This was referenced Apr 14, 2025
Open
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Apr 15, 2025
…when replica promoting (opensearch-project#17568) * add segment counter increment step setting Signed-off-by: guojialiang <[email protected]> * add changelog Signed-off-by: guojialiang <[email protected]> * change the default value directly Signed-off-by: guojialiang <[email protected]> * add CHANGELOG Signed-off-by: guojialiang <[email protected]> --------- Signed-off-by: guojialiang <[email protected]> Signed-off-by: Sriram Ganesh <[email protected]>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…when replica promoting (opensearch-project#17568) * add segment counter increment step setting Signed-off-by: guojialiang <[email protected]> * add changelog Signed-off-by: guojialiang <[email protected]> * change the default value directly Signed-off-by: guojialiang <[email protected]> * add CHANGELOG Signed-off-by: guojialiang <[email protected]> --------- Signed-off-by: guojialiang <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…when replica promoting (opensearch-project#17568) * add segment counter increment step setting Signed-off-by: guojialiang <[email protected]> * add changelog Signed-off-by: guojialiang <[email protected]> * change the default value directly Signed-off-by: guojialiang <[email protected]> * add CHANGELOG Signed-off-by: guojialiang <[email protected]> --------- Signed-off-by: guojialiang <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the problem raised by issue 17566
To avoid segment number conflicts, adjust the default step to 100000.
In order to adjust flexibly, I have added dynamic configuration at the index level.
Related Issues
Resolves 17566
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.