Skip to content

[Backport 2.x] Changes to support IP field in star tree indexing #17122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

[Backport 2.x] Changes to support IP field in star tree indexing #17122

merged 1 commit into from
Jan 27, 2025

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jan 25, 2025

Backport e6d71d2 from #16641.

@github-actions
Changes to support IP field in star tree indexing (#16641)
27988eb 
* Changes to support IP
---------

Signed-off-by: bharath-techie <[email protected]>
(cherry picked from commit e6d71d2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@bharath-techie bharath-techie added v2.19.0 Issues and PRs related to version 2.19.0 skip-changelog labels Jan 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2025

✅ Gradle check result for 27988eb: SUCCESS

@codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (bf42c3e) to head (27988eb).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...site/composite912/Composite912DocValuesWriter.java 36.36% 4 Missing and 3 partials ⚠️
...rch/index/compositeindex/datacube/IpDimension.java 73.68% 5 Missing ⚠️
...ndex/compositeindex/datacube/OrdinalDimension.java 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17122      +/-   ##
============================================
- Coverage     71.96%   71.95%   -0.02%     
- Complexity    65772    65805      +33     
============================================
  Files          5325     5326       +1     
  Lines        306459   306493      +34     
  Branches      44698    44702       +4     
============================================
- Hits         220554   220544      -10     
- Misses        67432    67478      +46     
+ Partials      18473    18471       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linuxpi
Copy link
Contributor

linuxpi commented Jan 27, 2025

Justification for codecov - #16641 (comment) we have integ tests to covering

@linuxpi linuxpi merged commit 3b27f4d into 2.x Jan 27, 2025
70 of 73 checks passed
@github-actions github-actions bot deleted the backport/backport-16641-to-2.x branch January 27, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linuxpi linuxpi linuxpi approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog v2.19.0 Issues and PRs related to version 2.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linuxpi @bharath-techie